Summary: | Build error on QT window version(..\..\..\WebCore\loader\FTPDirectoryDocument.cpp:233: error: `localtime_r' undec ) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jerry Kuo <sxk68> | ||||
Component: | WebKit Qt | Assignee: | George Staikos <staikos> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | ||||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | PC | ||||||
OS: | Windows Vista | ||||||
Attachments: |
|
Description
Jerry Kuo
2007-10-08 14:38:12 PDT
Created attachment 16592 [details]
Fix build
Comment on attachment 16592 [details]
Fix build
+#if PLATFORM(QT) && defined(Q_WS_WIN32)
Perhaps we should have a PLATFORM(QTWIN) or something similar? I foresee us having to make this check in many places in the future.
That's a lot of platforms to have special checks for in Platform.h. Qt does it all internally so after we check for Qt, I think we should use Qt's internal mechanisms. Remember that Qt supports well over half a dozen OS/platform configurations. Comment on attachment 16592 [details]
Fix build
r=me even if we don't add a PLATFORM(QTWIN), but I do think that would be a good idea. This can land on trunk.
Checked in. I can't help with the mingw issue but I'm happy to review a fix for that. |