Bug 15429 – Build error on QT window version(..\..\..\WebCore\loader\FTPDirectoryDocument.cpp:233: error: `localtime_r' undec )

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Jerry Kuo]

g++ -c -Wreturn-type -fno-strict-aliasing -O2 -frtti -fexceptions -mthreads -DUN 
ICODE -DQT_LARGEFILE_SUPPORT -DBUILDING_QT__=1 -DUSE_SYSTEM_MALLOC -DNDEBUG -DBU 
ILD_WEBKIT -DENABLE_ICONDATABASE=0 -DENABLE_XPATH=1 -DENABLE_SVG=1 -DWTF_CHANGES 
=1 -DBUILDING_QT__ -DWTF_USE_JAVASCRIPTCORE_BINDINGS=1 -DQT_DLL -DQT_NO_DEBUG -D 
QT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_THREAD_SUPPORT -I"c: 
\Qt\4.3.2\include\QtCore" -I"c:\Qt\4.3.2\include\QtCore" -I"c:\Qt\4.3.2\include\ 
QtNetwork" -I"c:\Qt\4.3.2\include\QtNetwork" -I"c:\Qt\4.3.2\include\QtGui" -I"c: 
\Qt\4.3.2\include\QtGui" -I"c:\Qt\4.3.2\include\QtXml" -I"c:\Qt\4.3.2\include\Qt 
Xml" -I"c:\Qt\4.3.2\include" -I"..\..\..\WebKit\qt\Api" -I"..\..\..\JavaScriptCo 
re" -I"..\..\..\JavaScriptCore\kjs" -I"..\..\..\JavaScriptCore\bindings" -I"..\. 
.\..\JavaScriptCore\bindings\c" -I"..\..\..\JavaScriptCore\wtf" -I"..\..\..\Java 
ScriptCore\ForwardingHeaders" -I"..\..\..\WebCore" -I"..\..\..\WebCore\Forwardin 
gHeaders" -I"..\..\..\WebCore\platform" -I"..\..\..\WebCore\platform\network" -I 
"..\..\..\WebCore\platform\graphics" -I"..\..\..\WebCore\loader" -I"..\..\..\Web 
Core\page" -I"..\..\..\WebCore\css" -I"..\..\..\WebCore\dom" -I"..\..\..\WebCore 
\bridge" -I"..\..\..\WebCore\editing" -I"..\..\..\WebCore\rendering" -I"..\..\.. 
\WebCore\history" -I"..\..\..\WebCore\xml" -I"..\..\..\WebCore\html" -I"tmp" -I" 
tmp" -I"tmp" -I"..\..\..\JavaScriptCore" -I"..\..\..\JavaScriptCore\kjs" -I"..\. 
.\..\JavaScriptCore\bindings" -I"..\..\..\JavaScriptCore\bindings\c" -I"..\..\.. 
\JavaScriptCore\wtf" -I"..\..\..\JavaScriptCore\bindings\qt" -I"..\..\..\JavaScr 
iptCore\pcre" -I"..\JavaScriptCore\kjs\tmp" -I"..\..\..\WebCore\platform\qt" -I" 
..\..\..\WebCore\platform\network\qt" -I"..\..\..\WebCore\platform\graphics\qt" 
-I"..\..\..\WebCore\platform\graphics\svg\qt" -I"..\..\..\WebCore\loader\qt" -I" 
..\..\..\WebCore\page\qt" -I"..\..\..\WebKit\qt\WebCoreSupport" -I"..\..\..\WebK 
it\qt\Api" -I"..\..\..\WebCore" -I"..\..\..\WebCore\ForwardingHeaders" -I"..\..\ 
..\..\WebKit" -I"..\..\..\JavaScriptCore\kjs" -I"..\..\..\JavaScriptCore\binding 
s" -I"..\..\..\WebCore\platform" -I"..\..\..\WebCore\platform\network" -I"..\..\ 
..\WebCore\platform\graphics" -I"..\..\..\WebCore\platform\graphics\svg" -I"..\. 
.\..\WebCore\platform\graphics\svg\filters" -I"..\..\..\WebCore\loader" -I"..\.. 
\..\WebCore\loader\icon" -I"..\..\..\WebCore\css" -I"..\..\..\WebCore\dom" -I".. 
\..\..\WebCore\page" -I"..\..\..\WebCore\bridge" -I"..\..\..\WebCore\editing" -I 
"..\..\..\WebCore\rendering" -I"..\..\..\WebCore\history" -I"..\..\..\WebCore\xm 
l" -I"..\..\..\WebCore\html" -I"..\..\..\WebCore\bindings\js" -I"..\..\..\WebCor 
e\ksvg2" -I"..\..\..\WebCore\ksvg2\css" -I"..\..\..\WebCore\ksvg2\svg" -I"..\..\ 
..\WebCore\ksvg2\misc" -I"..\..\..\WebCore\ksvg2\events" -I"..\..\..\WebCore\pla 
tform\image-decoders" -I"c:\Qt\4.3.2\include\ActiveQt" -I"release" -I"..\..\..\W 
ebCore" -I"" -I"." -I"c:\Qt\4.3.2\mkspecs\default" -o tmp\FTPDirectoryDocument.o 
 ..\..\..\WebCore\loader\FTPDirectoryDocument.cpp 
..\..\..\WebCore\loader\FTPDirectoryDocument.cpp: In function `WebCore::String W 
ebCore::processFileDateString(const WebCore::FTPTime&)': 
..\..\..\WebCore\loader\FTPDirectoryDocument.cpp:233: error: `localtime_r' undec 
lared (first use this function) 
..\..\..\WebCore\loader\FTPDirectoryDocument.cpp:233: error: (Each undeclared id 
entifier is reported only once for each function it appears in.) 
mingw32-make[2]: *** [tmp\FTPDirectoryDocument.o] Error 1

[George Staikos]

Created attachment 16592 [details]
Fix build

[Adam Roben (:aroben)]

Comment on attachment 16592 [details]
Fix build

+#if PLATFORM(QT) && defined(Q_WS_WIN32)

Perhaps we should have a PLATFORM(QTWIN) or something similar? I foresee us having to make this check in many places in the future.

[George Staikos]

That's a lot of platforms to have special checks for in Platform.h.  Qt does it all internally so after we check for Qt, I think we should use Qt's internal mechanisms.  Remember that Qt supports well over half a dozen OS/platform configurations.

[Adam Roben (:aroben)]

Comment on attachment 16592 [details]
Fix build

r=me even if we don't add a PLATFORM(QTWIN), but I do think that would be a good idea. This can land on trunk.

[George Staikos]

Checked in.  I can't help with the mingw issue but I'm happy to review a fix for that.