Bug 154287

Summary: Factor id mutation style invalidation code into a class
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Description Antti Koivisto 2016-02-16 04:49:09 PST
Not a recommended dynamic styling hook but for completeness sake.
Comment 1 Antti Koivisto 2016-02-16 06:45:20 PST
Created attachment 271427 [details]
patch
Comment 2 Andreas Kling 2016-02-16 08:31:05 PST
Comment on attachment 271427 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271427&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        However dynamic id changes are not common enought (nor recommended) to pay the memory cost of
> +        the required data structures.

Strongly agree with this.
Also s/enought/enough/

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:10555
> -		83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSXMLHttpRequestEventTarget.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> -		83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSXMLHttpRequestEventTarget.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
> +		83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> +		83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
>  		83E359A01BB1031D002CEB98 /* JSHTMLTimeElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSHTMLTimeElement.h; sourceTree = "<group>"; };

I don't know what these are about.
Comment 3 Antti Koivisto 2016-02-16 09:24:17 PST
https://trac.webkit.org/r196636