Bug 154287 – Factor id mutation style invalidation code into a class

• Component: CSS
• Status: RESOLVED FIXED

[Antti Koivisto]

Not a recommended dynamic styling hook but for completeness sake.

[Antti Koivisto]

Created attachment 271427 [details]
patch

[Andreas Kling]

Comment on attachment 271427 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271427&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        However dynamic id changes are not common enought (nor recommended) to pay the memory cost of
> +        the required data structures.

Strongly agree with this.
Also s/enought/enough/

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:10555
> -		83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSXMLHttpRequestEventTarget.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> -		83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSXMLHttpRequestEventTarget.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
> +		83D35AEF1C718D8400F70D5A /* JSXMLHttpRequestEventTarget.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXMLHttpRequestEventTarget.cpp; sourceTree = "<group>"; };
> +		83D35AF01C718D8400F70D5A /* JSXMLHttpRequestEventTarget.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSXMLHttpRequestEventTarget.h; sourceTree = "<group>"; };
>  		83E359A01BB1031D002CEB98 /* JSHTMLTimeElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSHTMLTimeElement.h; sourceTree = "<group>"; };

I don't know what these are about.

[Antti Koivisto]

https://trac.webkit.org/r196636