| Summary: | [CSS Box Alignment] New CSS Value 'normal' for Content Alignment | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | Javier Fernandez <jfernandez> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | achristensen, bfulgham, buildbot, cdumez, commit-queue, darin, hyatt, jfernandez, ossy, peavo, rego, rniwa, ryanhaddad, simon.fraser, svillar | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 60731, 91512, 133222, 133224 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Javier Fernandez
2016-02-16 02:29:08 PST
Created attachment 272333 [details]
Patch
Comment on attachment 272333 [details] Patch Attachment 272333 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/886761 New failing tests: svg/css/getComputedStyle-basic.xhtml Created attachment 272344 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 272333 [details] Patch Attachment 272333 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/886764 New failing tests: svg/css/getComputedStyle-basic.xhtml Created attachment 272346 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 272333 [details] Patch Attachment 272333 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/886762 New failing tests: svg/css/getComputedStyle-basic.xhtml Created attachment 272349 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 272414 [details]
Patch
Comment on attachment 272414 [details]
Patch
r=me
Comment on attachment 272414 [details] Patch Clearing flags on attachment: 272414 Committed r197503: <http://trac.webkit.org/changeset/197503> All reviewed patches have been landed. Closing bug. (In reply to comment #10) > Comment on attachment 272414 [details] > Patch > > Clearing flags on attachment: 272414 > > Committed r197503: <http://trac.webkit.org/changeset/197503> It broke the Windows build as the EWS noticed. c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\rendering\RenderGrid.cpp(1358): error C2084: function 'const WebCore::StyleContentAlignmentData &WebCore::normalValueBehavior(void)' already has a body (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\rendering\RenderingAllInOne.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] Comment on attachment 272414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272414&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:1095 > +static const StyleContentAlignmentData& normalValueBehavior() Having two different functions with the same name private to two different files is not compatible with all-in-one compiling, which we do on Windows. Just need the name to include “FlexibleBox”. > Source/WebCore/rendering/RenderGrid.cpp:1357 > +static const StyleContentAlignmentData& normalValueBehavior() Having two different functions with the same name private to two different files is not compatible with all-in-one compiling, which we do on Windows. Just need the name to include “Grid”. Landed the build fix (untested) in https://trac.webkit.org/r197509 Reopening to attach new patch. Created attachment 275704 [details]
Patch
Comment on attachment 275704 [details]
Patch
Builds and tests failing on EWS. Will review once we have a patch that compiles and the tests pass.
Comment on attachment 275704 [details]
Patch
This patch was not intended to this bug, sorry for the noise.
Comment on attachment 272333 [details]
Patch
This is the patch that finally landed.
Closing the bug as FIXED, since per comment #15, the fix for the win build has landed as well. Comment on attachment 272333 [details]
Patch
Wrong patch, this was not the one finally landed.
Comment on attachment 272414 [details]
Patch
This was the patch finally landed.
|