Summary: | FTL should support CompareEq(String:, String:) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, commit-queue, ggaren, keith_miller, mark.lam, msaboff, rniwa, saam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 154266 | ||||||||||||
Attachments: |
|
Description
Filip Pizlo
2016-02-15 16:56:38 PST
Created attachment 271478 [details]
voila
Haven't tried it yet
Created attachment 271484 [details]
maybe the patch
Still running tests.
Created attachment 271500 [details]
the patch
Comment on attachment 271500 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=271500&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7739 > + m_out.branch(m_out.notNull(left), usually(leftReadyCase), rarely(slowCase)); > + > + m_out.appendTo(leftReadyCase, rightReadyCase); Do you also need those checks for StringIdent? Comment on attachment 271500 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=271500&action=review >> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7739 >> + m_out.appendTo(leftReadyCase, rightReadyCase); > > Do you also need those checks for StringIdent? StringIdent is handled elsewhere. I believe that speculates that left and right are resolved, as opposed to this, which handles that on the slow path. But no matter how it does it, it's unrelated. Created attachment 271523 [details]
rebased patch
Landed in http://trac.webkit.org/changeset/196685 |