Summary: | HTMLFormElement.autocomplete should only return known values | ||
---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
Component: | Bindings | Assignee: | Chris Dumez <cdumez> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, darin, ggaren, rniwa, sam, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar, WebExposed |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
URL: | https://html.spec.whatwg.org/multipage/forms.html#dom-form-autocomplete | ||
Attachments: |
Description
Chris Dumez
2016-02-15 10:37:32 PST
Created attachment 271809 [details]
Patch
Comment on attachment 271809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271809&action=review > Source/WebCore/html/HTMLFormElement.cpp:872 > +const AtomicString& HTMLFormElement::autocomplete() const > +{ > + static NeverDestroyed<const AtomicString> on("on", AtomicString::ConstructFromLiteral); > + static NeverDestroyed<const AtomicString> off("off", AtomicString::ConstructFromLiteral); > + Why don't we just return String so that we don't have to construct these AtomicString's. Comment on attachment 271809 [details] Patch Attachment 271809 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/856274 New failing tests: fast/forms/autocomplete.html Created attachment 271812 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 271809 [details] Patch Attachment 271809 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/856276 New failing tests: fast/forms/autocomplete.html Created attachment 271813 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 271809 [details] Patch Attachment 271809 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/856277 New failing tests: fast/forms/autocomplete.html Created attachment 271814 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 271815 [details]
Patch
Comment on attachment 271815 [details] Patch Clearing flags on attachment: 271815 Committed r196846: <http://trac.webkit.org/changeset/196846> All reviewed patches have been landed. Closing bug. |