Bug 154245 – Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'

• Component: Bindings
• Status: RESOLVED FIXED

[Chris Dumez]

Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'.

E.g. the following no longer works:
var f = window.addEventListener
f.call(undefined, "click", function() {});

It should use the global window object.

This is causing Dromaeo/cssquery-dojo.html to fail.

[Chris Dumez]

Created attachment 271346 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 271346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271346&action=review

> LayoutTests/fast/dom/Window/addEventListener-implicit-this.html:23
> +bodyDispatchEventFunction = document.body.dispatchEvent;
> +shouldBeTrue("bodyDispatchEventFunction.call(undefined, new Event('myevent'))");

Why don't we try some non-Node event target such as XHR object?

[Chris Dumez]

Created attachment 271353 [details]
Patch

[Chris Dumez]

Comment on attachment 271353 [details]
Patch

Clearing flags on attachment: 271353

Committed r196588: <http://trac.webkit.org/changeset/196588>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 271346 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271346&action=review
> 
> > LayoutTests/fast/dom/Window/addEventListener-implicit-this.html:23
> > +bodyDispatchEventFunction = document.body.dispatchEvent;
> > +shouldBeTrue("bodyDispatchEventFunction.call(undefined, new Event('myevent'))");
> 
> Why don't we try some non-Node event target such as XHR object?

I added coverage for XHR before landing and checks that the test behaves the same in Chrome and Firefox.