Summary: | Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this' | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, cgarcia, commit-queue, darin, ggaren, ossy, rniwa, sam | ||||||
Priority: | P2 | Keywords: | WebExposed | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | http://heycam.github.io/webidl/#ImplicitThis | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 154170 | ||||||||
Attachments: |
|
Description
Chris Dumez
2016-02-15 09:02:48 PST
Created attachment 271346 [details]
Patch
Comment on attachment 271346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271346&action=review > LayoutTests/fast/dom/Window/addEventListener-implicit-this.html:23 > +bodyDispatchEventFunction = document.body.dispatchEvent; > +shouldBeTrue("bodyDispatchEventFunction.call(undefined, new Event('myevent'))"); Why don't we try some non-Node event target such as XHR object? Created attachment 271353 [details]
Patch
Comment on attachment 271353 [details] Patch Clearing flags on attachment: 271353 Committed r196588: <http://trac.webkit.org/changeset/196588> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > Comment on attachment 271346 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271346&action=review > > > LayoutTests/fast/dom/Window/addEventListener-implicit-this.html:23 > > +bodyDispatchEventFunction = document.body.dispatchEvent; > > +shouldBeTrue("bodyDispatchEventFunction.call(undefined, new Event('myevent'))"); > > Why don't we try some non-Node event target such as XHR object? I added coverage for XHR before landing and checks that the test behaves the same in Chrome and Firefox. |