Bug 154202

Summary: Eliminate the need for WTFCrashImpl().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: Web Template FrameworkAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, commit-queue, ddkilzer, ossy, peavo
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2016-02-12 16:11:23 PST
Patch coming.
Attachments
proposed patch. (5.74 KB, patch)
2016-02-12 16:25 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-02-12 16:25:14 PST
Created attachment 271243 [details] proposed patch.
WebKit Commit Bot
Comment 2 2016-02-12 17:02:56 PST
Attachment 271243 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:245: Multi line control clauses should use braces. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Assertions.h:252: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2016-02-13 13:52:10 PST
Comment on attachment 271243 [details] proposed patch. I'm also marking this cq+, so that it lands ASAP. The change in crash signatures due to WTFCrashImpl is a huge problem, so if this doesn't work, we'll just need to roll out the whole set of patches.
WebKit Commit Bot
Comment 4 2016-02-13 14:39:53 PST
Comment on attachment 271243 [details] proposed patch. Clearing flags on attachment: 271243 Committed r196554: <http://trac.webkit.org/changeset/196554>
WebKit Commit Bot
Comment 5 2016-02-13 14:39:58 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2016-02-14 00:03:00 PST
It broke the Wincairo build, cc-ing port maintainers.
Mark Lam
Comment 7 2016-02-15 09:18:58 PST
(In reply to comment #6) > It broke the Wincairo build, cc-ing port maintainers. Ossy, any details on the breakage? What is the error message? Thanks.
Alex Christensen
Comment 8 2016-02-15 09:22:35 PST
https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/53937/steps/compile-webkit/logs/stdio Not a problem with this patch. I think the forwarding headers from WTF are being copied pre-link instead of pre-build when using Ninja instead of Visual Studio to drive the build. I'll need to look into this, but this is not a problem with this patch.
Note You need to log in before you can comment on or make changes to this bug.