Bug 154163

Summary:

Factor class change style invalidation code into a class

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

154167, 154220

Bug Blocks:

Attachments:

Description	Flags
patch	kling: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews113 for mac-yosemite	none
patch	none
for bots	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews115 for mac-yosemite	none
patch	none

Antti Koivisto

Reported 2016-02-12 04:53:18 PST

Yo dawg...

Attachments
patch (20.19 KB, patch) 2016-02-12 05:06 PST, Antti Koivisto	kling: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (470.25 KB, application/zip) 2016-02-12 05:41 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (693.96 KB, application/zip) 2016-02-12 05:44 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-yosemite (524.17 KB, application/zip) 2016-02-12 05:46 PST, Build Bot	no flags	Details
patch (20.25 KB, patch) 2016-02-12 06:34 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
for bots (20.20 KB, patch) 2016-02-12 08:51 PST, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (837.08 KB, application/zip) 2016-02-12 09:42 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (854.98 KB, application/zip) 2016-02-12 09:45 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (934.47 KB, application/zip) 2016-02-12 09:57 PST, Build Bot	no flags	Details
patch (20.20 KB, patch) 2016-02-13 15:00 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2016-02-12 05:06:26 PST

Created attachment 271167 [details] patch

Build Bot

Comment 2 2016-02-12 05:41:28 PST

Comment on attachment 271167 [details] patch Attachment 271167 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/819222 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2016-02-12 05:41:30 PST

Created attachment 271168 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-02-12 05:44:12 PST

Comment on attachment 271167 [details] patch Attachment 271167 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/819227 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2016-02-12 05:44:14 PST

Created attachment 271169 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-02-12 05:45:59 PST

Comment on attachment 271167 [details] patch Attachment 271167 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/819211 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2016-02-12 05:46:01 PST

Created attachment 271170 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 8 2016-02-12 06:34:01 PST

Created attachment 271173 [details] patch

Antti Koivisto

Comment 9 2016-02-12 07:05:50 PST

https://trac.webkit.org/r196470

WebKit Commit Bot

Comment 10 2016-02-12 07:47:32 PST

Re-opened since this is blocked by bug 154167

Antti Koivisto

Comment 11 2016-02-12 08:51:11 PST

Created attachment 271175 [details] for bots

Build Bot

Comment 12 2016-02-12 09:42:01 PST

Comment on attachment 271175 [details] for bots Attachment 271175 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/819972 New failing tests: media/video-controls-audiotracks-trackmenu.html media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html media/video-controls-captions-trackmenu-localized.html media/controls-drag-timebar.html media/controls/elementOrder.html media/controls/track-menu.html media/media-controls-drag-timeline-set-controls-property.html media/controls/statusDisplay.html media/track/track-manual-mode.html media/video-controls-captions-trackmenu-sorted.html media/video-trackmenu-selection.html

Build Bot

Comment 13 2016-02-12 09:42:03 PST

Created attachment 271178 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 14 2016-02-12 09:45:52 PST

Comment on attachment 271175 [details] for bots Attachment 271175 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/819978 New failing tests: media/video-controls-audiotracks-trackmenu.html media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html media/video-controls-captions-trackmenu-localized.html media/controls-drag-timebar.html media/controls/elementOrder.html media/controls/track-menu.html media/media-controls-drag-timeline-set-controls-property.html media/controls/statusDisplay.html media/track/track-manual-mode.html media/video-controls-captions-trackmenu-sorted.html media/video-trackmenu-selection.html

Build Bot

Comment 15 2016-02-12 09:45:54 PST

Created attachment 271179 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 16 2016-02-12 09:57:31 PST

Comment on attachment 271175 [details] for bots Attachment 271175 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/819985 New failing tests: media/video-controls-audiotracks-trackmenu.html media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html media/video-controls-captions-trackmenu-localized.html media/controls/elementOrder.html media/controls/track-menu.html media/media-controls-drag-timeline-set-controls-property.html media/track/track-manual-mode.html media/video-controls-captions-trackmenu-sorted.html media/video-trackmenu-selection.html

Build Bot

Comment 17 2016-02-12 09:57:33 PST

Created attachment 271181 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5

Antti Koivisto

Comment 18 2016-02-13 15:00:37 PST

Created attachment 271299 [details] patch

Antti Koivisto

Comment 19 2016-02-14 01:57:50 PST

https://trac.webkit.org/r196560

Note You need to log in before you can comment on or make changes to this bug.