Bug 154136

Summary: [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
achristensen: review+
Patch for landing
none
Patch for landing none

Jer Noble
Reported 2016-02-11 15:04:20 PST
[Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
Attachments
Patch (15.82 KB, patch)
2016-02-12 10:16 PST, Jer Noble 		achristensen: review+
DetailsFormatted DiffDiff
Patch for landing (17.58 KB, patch)
2016-02-12 12:59 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (21.94 KB, patch)
2016-02-12 13:46 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-02-12 10:16:17 PST
Created attachment 271185 [details] Patch
Alex Christensen
Comment 2 2016-02-12 11:42:17 PST
Comment on attachment 271185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271185&action=review You forgot a change in MediaPlayerPrivateAVFoundationObjC.mm to fix iOS. > Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:-345 > - _client = std::make_unique<WebCoreNSURLSessionDataTaskClient>(self); Is _client used at all? Should we remove it completely?
Jer Noble
Comment 3 2016-02-12 12:59:27 PST
Created attachment 271207 [details] Patch for landing
Jer Noble
Comment 4 2016-02-12 13:46:39 PST
Created attachment 271216 [details] Patch for landing
Jer Noble
Comment 5 2016-02-12 14:13:34 PST
Committed r196506: <http://trac.webkit.org/changeset/196506>
Note You need to log in before you can comment on or make changes to this bug.