Bug 154123

Summary: The sampling profiler's stack walker methods should be marked with SUPPRESS_ASAN
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, joepeck, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch mark.lam: review+

Saam Barati
Reported 2016-02-11 12:46:47 PST
The whole premise here is that we're walking another thread's stack, so ASan won't be happy about this.
Attachments
patch (1.71 KB, patch)
2016-02-11 12:52 PST, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-02-11 12:52:48 PST
Created attachment 271072 [details] patch
Mark Lam
Comment 2 2016-02-11 12:53:41 PST
Comment on attachment 271072 [details] patch r=me
Saam Barati
Comment 3 2016-02-11 13:05:00 PST
landed in: http://trac.webkit.org/changeset/196432
Joseph Pecoraro
Comment 4 2016-02-11 14:15:53 PST
<rdar://problem/24589661>
Note You need to log in before you can comment on or make changes to this bug.