Bug 15410 – GTK: compilation error, incomplete rename of marshalling functions

• Component: WebKit API
• Status: RESOLVED INVALID

[Lars Lindner]

With revision 26101 or a previous one the GTK build target was broken. Compilation fails with:

/home/lars/oss/WebKit/WebKitBuild/Release/lib/libWebKitGtk.so: undefined reference to `webkit_marshal_VOID__STRING_STRING'
collect2: ld returned 1 exit status
make[1]: *** [GtkLauncher] Fehler 1
make[1]: Leaving directory `/home/lars/oss/WebKit/WebKitBuild/Release/WebKitTools/GtkLauncher'
make: *** [sub-WebKitTools-GtkLauncher-make_default-ordered] Fehler 2

It seems like the marshalling functions were renamed from webkit_marshal_*
to webkit_gtk_marshal_* without adapting the code at some places.

Affected files :

gtk/Api/webkitgtkpage.cpp
gtk/Api/webkitgtkframe.cpp

[Lars Lindner]

Created attachment 16575 [details]
Fix for GTK compilation issues

[Adam Roben (:aroben)]

Comment on attachment 16575 [details]
Fix for GTK compilation issues

This patch moves things in the wrong direction. All the WebKit/gtk API methods were recently renamed from webkit_gtk_* to just webkit_*. We need to rename these marshallers as well.

[Mark Rowe (bdash)]

I suspect the generated file webkitgtk-marshal.h/cpp has not been regenerated in your case. I cannot see anything incorrect in the source that you indicate, so I would suggest you try a clean build and see if that improves things.

[Lars Lindner]

You are right. Compiling with a clean checkout solves the problem. Thanks for the help!

So this problem report is invalid and can be closed.