Bug 154083 – CSSSegmentedFontFace does not need to be reference counted

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

CSSSegmentedFontFace does not need to be reference counted

[Myles C. Maxfield]

Created attachment 271021 [details]
Patch

[Antti Koivisto]

Comment on attachment 271021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271021&action=review

> Source/WebCore/css/CSSSegmentedFontFace.h:43
> -class CSSSegmentedFontFace : public RefCounted<CSSSegmentedFontFace> {
> +class CSSSegmentedFontFace {
>  public:

You might want to add WTF_MAKE_FAST_ALLOCATED;

[Myles C. Maxfield]

Committed r196388: <http://trac.webkit.org/changeset/196388>

[Myles C. Maxfield]

Committed r196393: <http://trac.webkit.org/changeset/196393>

[Darin Adler]

Comment on attachment 271021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271021&action=review

> Source/WebCore/css/CSSFontSelector.cpp:472
> +    std::unique_ptr<CSSSegmentedFontFace>& face = segmentedFontFaceCache.add(traitsMask, nullptr).iterator->value;

I think auto& is an improvement for code like this; what’s the need to restate the type on this line of code?

> Source/WebCore/css/CSSSegmentedFontFace.h:42
> +class CSSSegmentedFontFace {

Maybe mark this class final. Along with the lack of virtual functions, makes it clear there’s no polymorphism here.