Bug 154068 – Loading big websites causes the browser to crash

• Component: New Bugs
• Status: RESOLVED FIXED

[paladox]

Hi loading large websites causes the browser to crash.

To reproduce please follow these steps

Use iOS 9.2 with an iPhone or iPad.

* go to https://gerrit.wikimedia.org/r/#/c/269651/ click on the layout.yaml file. When it's loading the browser will crash.

* since Google chrome is a fork of WebKit I tested Google chrome on Windows and manages to load the website without crashes and loads pretty fast. I presume the fix is somewhere in Google chrome. We should backported it here since reviewing changes is important even big files with little changes.

[paladox]

I've filed this bug here https://phabricator.wikimedia.org/T126442 for that file. But we Should fix the bug that causes loading large files through web browser to crash

[Radar WebKit Bug Importer]

<rdar://problem/24629358>

[Simon Fraser (smfr)]

What does "click on the layout.yaml file" mean? https://gerrit.wikimedia.org/r/#/c/269651/1/zuul/layout.yaml is a small document (a diff).

[paladox]

(In reply to comment #3)
> What does "click on the layout.yaml file" mean?
> https://gerrit.wikimedia.org/r/#/c/269651/1/zuul/layout.yaml is a small
> document (a diff).
It means to click on the file that I have linked meaning when you click on the link, click on the file to view the diff. The file will not load in WebKit it just crashed whereas it loads in chrome.

[Simon Fraser (smfr)]

Can you paste the actual url for the page that crashes on iOS but loads in Chrome?

[paladox]

(In reply to comment #5)
> Can you paste the actual url for the page that crashes on iOS but loads in
> Chrome?

Ok heres the link https://gerrit.wikimedia.org/r/#/c/270938/4/zuul/layout.yaml It works in chrome but crashes on ios probably it happends to webkit.

[Simon Fraser (smfr)]

Ah, that's the one I tried. It does indeed run out of memory on older devices.

[paladox]

(In reply to comment #7)
> Ah, that's the one I tried. It does indeed run out of memory on older
> devices.

Ok but it also happends on newer devices such as an ipad pro and a iPhone 6. Ipad pro is 128gb and iPhone 6 plus a 64gb.

Google chrome works on windows. I doint think it works on ios since it uses the same engine and safari.

[Andreas Kling]

Created attachment 271650 [details]
Patch

[WebKit Commit Bot]

Attachment 271650 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Created attachment 271652 [details]
Patch

[paladox]

(In reply to comment #11)
> Created attachment 271652 [details]
> Patch

Thanks.

[Simon Fraser (smfr)]

Very nice.

[WebKit Commit Bot]

Comment on attachment 271652 [details]
Patch

Clearing flags on attachment: 271652

Committed r196761: <http://trac.webkit.org/changeset/196761>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[paladox]

Hi do you know when this will be added To an iOS build so I can test to see if the crashed stop on the iPhone please.

[paladox]

If the fix is included in iOS 9.3 beta 5 then it isent working still crashing. If it is still to be included when will that be please.

[Saam Barati]

(In reply to comment #17)
> If the fix is included in iOS 9.3 beta 5 then it isent working still
> crashing. If it is still to be included when will that be please.

Apple does not comment on the timing or content of future releases.