Summary: | Modern IDB: Ref cycle between IDBObjectStore and IDBTransaction | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, alecflett, buildbot, commit-queue, jsbell, rniwa | ||||||||||
Priority: | P2 | ||||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 149117, 154015 | ||||||||||||
Attachments: |
|
Description
Brady Eidson
2016-02-09 21:03:32 PST
Created attachment 270969 [details]
Patch v1
Comment on attachment 270969 [details] Patch v1 Attachment 270969 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/807768 New failing tests: storage/indexeddb/objectstore-basics-private.html storage/indexeddb/modern/abort-objectstore-info-private.html storage/indexeddb/modern/abort-objectstore-info.html storage/indexeddb/metadata.html storage/indexeddb/objectstore-basics.html storage/indexeddb/metadata-private.html Created attachment 270974 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270969 [details] Patch v1 Attachment 270969 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/807775 New failing tests: storage/indexeddb/objectstore-basics-private.html storage/indexeddb/modern/abort-objectstore-info-private.html storage/indexeddb/modern/abort-objectstore-info.html storage/indexeddb/metadata.html storage/indexeddb/objectstore-basics.html storage/indexeddb/metadata-private.html Created attachment 270975 [details]
Archive of layout-test-results from ews113 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
(In reply to comment #4) > Comment on attachment 270969 [details] > Patch v1 > > Attachment 270969 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/807775 > > New failing tests: > storage/indexeddb/objectstore-basics-private.html > storage/indexeddb/modern/abort-objectstore-info-private.html > storage/indexeddb/modern/abort-objectstore-info.html > storage/indexeddb/metadata.html > storage/indexeddb/objectstore-basics.html > storage/indexeddb/metadata-private.html Very surprising, looking locally. Easy bug. Building and testing now. Created attachment 271004 [details]
Patch v2
Comment on attachment 271004 [details] Patch v2 Clearing flags on attachment: 271004 Committed r196373: <http://trac.webkit.org/changeset/196373> All reviewed patches have been landed. Closing bug. Comment on attachment 271004 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=271004&action=review > Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:183 > + ASSERT(!isFinishedOrFinishing()); > + m_state = state; Can we add this: ASSERT(isFinishedOrFinishing()); after setting m_state? (In reply to comment #11) > Comment on attachment 271004 [details] > Patch v2 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271004&action=review > > > Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:183 > > + ASSERT(!isFinishedOrFinishing()); > > + m_state = state; > > Can we add this: > > ASSERT(isFinishedOrFinishing()); > > after setting m_state? Not a bad idea! Reopening to track that feedback so I don't forget it. |