Bug 154037

Summary: Window should have its 'constructor' property on the prototype
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, cgarcia, commit-queue, darin, ggaren, oliver, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://heycam.github.io/webidl/#interface-prototype-object
Bug Depends on: 153920    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-02-09 09:49:24 PST
Window should have its 'constructor' property on the prototype as per: http://heycam.github.io/webidl/#interface-prototype-object Similarly to other interfaces. This matches the behavior of Firefox and Chrome also. Our bindings generator currently puts this attribute on the instance because Window has the [CheckSecurity] IDL extended attribute. However, security-wise, moving 'constructor' to the prototype should be safe considering that it is not possible to access a Window's prototype cross-origin.
Attachments
Patch (23.07 KB, patch)
2016-02-16 20:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-02-09 09:51:31 PST
We just need to make sure that accessing crossOriginWindow.constructor still fails due to security checks.
Radar WebKit Bug Importer
Comment 2 2016-02-16 16:59:34 PST
<rdar://problem/24689078>
Chris Dumez
Comment 3 2016-02-16 20:56:19 PST
Created attachment 271527 [details] Patch
WebKit Commit Bot
Comment 4 2016-02-17 00:38:27 PST
Comment on attachment 271527 [details] Patch Clearing flags on attachment: 271527 Committed r196690: <http://trac.webkit.org/changeset/196690>
WebKit Commit Bot
Comment 5 2016-02-17 00:38:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.