Bug 154036 – All 32-bit plug-ins should use the XPC service

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

All 32-bit plug-ins should use the XPC service

[Anders Carlsson]

Created attachment 270937 [details]
Patch

Comment on attachment 270937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270937&action=review

> Source/WebKit2/ChangeLog:14
> +        1. Shimming mach_vm_map and make sure to add the VM_PROT_EXECUTABLE bit to any memory in the tiny zone.

“making sure” or “to make sure”

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:209
> +static bool isMallocMemoryTag(int tag)

Should this be called isMallocTinyMemoryTag, since it only checks for that, while there are other malloc tags?

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:220
> +static bool shouldMapMallocMemoryExecutable = false;

We don’t initialize statics to their default values.

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:494
> +                const char* pathSnippet = "/Silverlight.plugin/Contents/MacOS/CoreCLR.bundle/Contents/MacOS/coreclr";

s/Snippet/Suffix/ ?

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:496
> +                int pathSnippetLength = strlen(pathSnippet);

Here too.

> Source/WebKit2/PluginProcess/mac/PluginProcessShim.h:32
> +#include <mach/mach_vm.h>

This can go into the implementation file.

[Anders Carlsson]

Created attachment 270938 [details]
Patch

[Anders Carlsson]

Committed r196321: <http://trac.webkit.org/changeset/196321>