Bug 154008 – Web Inspector: Extract a few common unicode characters into global variables

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

* SUMMARY
Extract a few common unicode characters into global variables

We use `ellipsis` and `emDash` in a lot of places, even storing into a temporary well named global. Lets just make them always available in Utilities to avoid having to look them up everywhere.

[Radar WebKit Bug Importer]

<rdar://problem/24555688>

[Joseph Pecoraro]

Created attachment 270881 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

> ...even storing into a temporary well named global...

I meant: temporary well named variable.

[Timothy Hatcher]

Comment on attachment 270881 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=270881&action=review

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:28
> +emDash = "\u2014";
> +ellipsis = "\u2026";

var or const?

[Joseph Pecoraro]

Comment on attachment 270881 [details]
[PATCH] Proposed Fix

I think we want it to be obvious that we are leaking it to the global namespace. Const wouldn't work as that would scope it to this lexical scope. var would be fine.

[Joseph Pecoraro]

Created attachment 270882 [details]
[PATCH] For Landing

[WebKit Commit Bot]

Comment on attachment 270882 [details]
[PATCH] For Landing

Clearing flags on attachment: 270882

Committed r196275: <http://trac.webkit.org/changeset/196275>