Summary: | Layout tests freeze in HashTable::lookup | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hyatt | ||||
Priority: | P1 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | Mac (PowerPC) | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2007-10-06 05:24:43 PDT
Created attachment 16567 [details]
proposed fix
Looks like this issue isn't present on trunk - at least, I couldn't find such code there. Comment on attachment 16567 [details]
proposed fix
The change looks sane. I don't understand the removal of the -1 checks (or why they were there in the first place).
I have removed the -1 checks because there was an unchecked call to [font pointSize] in this function anyway - so guarding against the same problem in other places wasn't really helpful. Comment on attachment 16567 [details]
proposed fix
If the checks for -1 really aren't necessary, then perhaps m_font can be changed into a RetainPtr?
r=me
> If the checks for -1 really aren't necessary, then perhaps m_font can be
> changed into a RetainPtr?
It's OK for m_font to be -1 (it's a special value used for "Deleted"), but apparently not for setFont() parameter.
Committed revision 26105. Thanks for catching this. (In reply to comment #6) > It's OK for m_font to be -1 (it's a special value used for "Deleted"), but > apparently not for setFont() parameter. Oops, one of the removed checks was necessary in fact: - if (m_font && m_font != (NSFont*)-1) + if (m_font) Restored it in r26107. |