Bug 153928

Summary: Testing with remote server cache is unusably slow
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, jond, kling, koivisto, slewis, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug cdumez: review+, cdumez: commit-queue-

Description Ryosuke Niwa 2016-02-05 14:54:36 PST
Don't use single process mode of httpd. It even randomly crashes :(
Comment 1 Ryosuke Niwa 2016-02-05 14:59:20 PST
Created attachment 270774 [details]
Fixes the bug
Comment 2 Chris Dumez 2016-02-05 15:35:53 PST
Comment on attachment 270774 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=270774&action=review

r=me with nit fixes

> Websites/perf.webkit.org/ChangeLog:11
> +        Since httpd exits immediately when laucnehd in multi-process mode, remote-cache-server.py (renamed from

typo: "launched"

> Websites/perf.webkit.org/tools/remote-cache-server.py:22
> +        httpd_mutax_dir = tempfile.mkdtemp()

typo: mutex?

> Websites/perf.webkit.org/tools/remote-cache-server.py:14
> +        command = sys.argv[1]

I think we should exit early and with a clear error message when the parameter is missing.

Otherwise the user will get the following error message and wonder what he/she did wrong:
Unknown command: None
Comment 3 Ryosuke Niwa 2016-02-05 16:09:12 PST
Landed in r196195.