Bug 153902

Summary: use proper ifdef for platform in PlatformEventFactory
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebCore JavaScriptAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: aakash_jain, ap, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Aakash Jain
Reported 2016-02-04 16:22:16 PST
PlatformEventFactory class is defined in both iOS and mac. We should use #ifdef(platform-name) in respective header files.
Attachments
Proposed patch (1.87 KB, patch)
2016-02-04 16:24 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2016-02-04 16:24:35 PST
Created attachment 270704 [details] Proposed patch
Alexey Proskuryakov
Comment 2 2016-02-04 17:14:24 PST
Comment on attachment 270704 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=270704&action=review > Source/WebCore/ChangeLog:3 > + use proper ifdef for platform in PlatformEventFactory I'm not sure if that's something that we actually want. Darin mentioned it in the past that we intentionally don't conditionalize headers, at least in some cases.
Daniel Bates
Comment 3 2016-02-04 19:51:21 PST
(In reply to comment #0) > PlatformEventFactory class is defined in both iOS and mac. Can you elaborate on this? Notice that we explicitly exclude source file PlatformEventFactoryMac.mm when building for iOS by [1] and exclude PlatformEventFactoryIOS.mm when building for OS X by [2]. [1] <http://trac.webkit.org/browser/trunk/Source/WebCore/Configurations/WebCore.xcconfig?rev=196164#L90> [2] <http://trac.webkit.org/browser/trunk/Source/WebCore/Configurations/WebCore.xcconfig?rev=196164#L91>
Darin Adler
Comment 4 2016-02-06 10:30:00 PST
Comment on attachment 270704 [details] Proposed patch What’s the practical benefit you expect here? Is there some existing file including these headers on the wrong platform? Are we worried that people will make that mistake in the future?
Aakash Jain
Comment 5 2016-02-06 11:13:41 PST
emailed you the details.
Note You need to log in before you can comment on or make changes to this bug.