Bug 153893

Summary:

Use scope stack instead of nested TreeResolvers for shadow trees

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, kling, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2016-02-04 13:50:33 PST

Use more future proof approach.

Comment 1 Antti Koivisto 2016-02-05 08:37:41 PST

Created attachment 270745 [details]
patch

Comment 2 Andreas Kling 2016-02-06 03:25:17 PST

Comment on attachment 270745 [details]
patch

r=me

Comment 3 Ryosuke Niwa 2016-02-06 12:48:54 PST

Comment on attachment 270745 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270745&action=review

> Source/WebCore/style/StyleTreeResolver.h:80
> +    struct Scope : RefCounted<Scope> {

Does this really need to be RefCounted?

Comment 4 Ahmad Saleem 2022-10-25 08:45:54 PDT

landed - https://github.com/WebKit/WebKit/commit/b8cc4b3a7442887470b8c810f1b6dd2c70008e15

and didn't backed out.

Although @rniwa comment was not addressed.

Marking this as "RESOLVED FIXED" though.