Bug 153893

Summary: Use scope stack instead of nested TreeResolvers for shadow trees
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, kling, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2016-02-04 13:50:33 PST
Use more future proof approach.
Attachments
patch (13.38 KB, patch)
2016-02-05 08:37 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2016-02-05 08:37:41 PST
Created attachment 270745 [details] patch
Andreas Kling
Comment 2 2016-02-06 03:25:17 PST
Comment on attachment 270745 [details] patch r=me
Ryosuke Niwa
Comment 3 2016-02-06 12:48:54 PST
Comment on attachment 270745 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=270745&action=review > Source/WebCore/style/StyleTreeResolver.h:80 > + struct Scope : RefCounted<Scope> { Does this really need to be RefCounted?
Ahmad Saleem
Comment 4 2022-10-25 08:45:54 PDT
landed - https://github.com/WebKit/WebKit/commit/b8cc4b3a7442887470b8c810f1b6dd2c70008e15 and didn't backed out. Although @rniwa comment was not addressed. Marking this as "RESOLVED FIXED" though.
Note You need to log in before you can comment on or make changes to this bug.