Summary: | [GTK] Web Inspector: Add new GTK+ icons for instrument icons | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||||||||
Component: | Web Inspector | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | agomez, aperez, bugs-noreply, cgarcia, commit-queue, graouts, Hironori.Fujii, inspector-bugzilla-changes, joepeck, mcatanzaro, mrobinson, webkit-bug-importer | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | All | ||||||||||||||||||
OS: | All | ||||||||||||||||||
Bug Depends on: | 153884 | ||||||||||||||||||
Bug Blocks: | |||||||||||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2016-02-04 13:19:51 PST
Expected paths: Images/NetworkInstrument.svg Images/ScriptsInstrument.svg Images/MemoryInstrument.svg Images/LayoutInstrument.svg Images/RenderingFramesInstrument.svg > Images/MemoryInstrument.svg
Note this is only needed when linux ports start getting ENABLE(RESOURCE_USAGE), but it might be worth adding an icon in the meantime.
HeapAllocationsInstrument.svg has been added (Bug 155731) Created attachment 307106 [details]
Patch
Created attachment 307107 [details]
Apple images and proposed ones
Created attachment 307109 [details]
screenshot of before and after this fix
Created attachment 307111 [details]
Patch
Andres, is it OK? Comment on attachment 307111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=307111&action=review r=me, but consider simplifying the svg a bit! > Source/WebInspectorUI/UserInterface/Images/gtk/NetworkInstrument.svg:12 > +<svg > + xmlns:dc="http://purl.org/dc/elements/1.1/" > + xmlns:cc="http://creativecommons.org/ns#" > + xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" > + xmlns:svg="http://www.w3.org/2000/svg" > + xmlns="http://www.w3.org/2000/svg" > + xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" > + xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" > + sodipodi:docname="NetworkInstrument.svg" There is a pretty good chance that you can reduce the size of these SVGs significantly by eliminating unnecessary references and simplifying a bit. • the metadata is not necessary for rendering (dc, cc, rdf) • inkscape / sodipodi attributes appear to be for editors only, they won't affect rendering • docname is not necessary, this file already has a name • some style attributes have unnecessary properties (especially for fonts) • some values can be simplified as the large number of decimals are unlikely to be necessary in some cases (.0002 and .9997) I can understand if you want to leave some of the attributes to make future editing easier, but we've found that is often not the case with our images. You may want to get a review from GTK folks (Andres / Michael). The patch looks good from an inspector point of view. Thank you for reviewing, Joseph. I didn't know about Andres's script to optimize SVG. Bug 143476 - [GTK] Web Inspector: Optimize SVG images This script can not reproduce the same SVG files at the moment because root elements of all SVG files are added id="root" in Bug 150602. Created attachment 308345 [details]
Patch
Created attachment 308348 [details]
screenshot of before and after this fix
Created attachment 308350 [details]
Apple images and proposed ones
Comment on attachment 308345 [details]
Patch
We really have to remove the nonfree Apple images, it's just getting ridiculous at this point.
Comment on attachment 308345 [details] Patch Clearing flags on attachment: 308345 Committed r215869: <http://trac.webkit.org/changeset/215869> All reviewed patches have been landed. Closing bug. |