Bug 153884

Summary:

Web Inspector: New timeline images for instruments

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, bburg, commit-queue, graouts, joepeck, jond, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

153892

Attachments:

Description	Flags
[IMAGE] New Icons	none
[PATCH] Proposed Fix	timothy: review+, buildbot: commit-queue-
[IMAGE] Icons @2x	none
Archive of layout-test-results from ews113 for mac-yosemite	none
[PATCH] For Landing	none

Joseph Pecoraro

Reported 2016-02-04 12:30:12 PST

* SUMMARY New timeline images for instruments * NOTES - Adds a new image for the Memory instrument

Attachments
[IMAGE] New Icons (118.76 KB, image/png) 2016-02-04 13:25 PST, Joseph Pecoraro	no flags	Details
[PATCH] Proposed Fix (59.96 KB, patch) 2016-02-04 13:26 PST, Joseph Pecoraro	timothy: review+ buildbot: commit-queue-	Details Formatted Diff Diff
[IMAGE] Icons @2x (316.47 KB, image/png) 2016-02-04 13:49 PST, Joseph Pecoraro	no flags	Details
Archive of layout-test-results from ews113 for mac-yosemite (886.79 KB, application/zip) 2016-02-04 14:02 PST, Build Bot	no flags	Details
[PATCH] For Landing (60.01 KB, patch) 2016-02-04 14:15 PST, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-02-04 12:31:11 PST

<rdar://problem/24509429>

Joseph Pecoraro

Comment 2 2016-02-04 13:25:51 PST

Created attachment 270688 [details] [IMAGE] New Icons

Joseph Pecoraro

Comment 3 2016-02-04 13:26:42 PST

Created attachment 270689 [details] [PATCH] Proposed Fix I have to test on @2x, so no cq? at the moment.

Joseph Pecoraro

Comment 4 2016-02-04 13:49:28 PST

Created attachment 270691 [details] [IMAGE] Icons @2x

Build Bot

Comment 5 2016-02-04 14:02:50 PST

Comment on attachment 270689 [details] [PATCH] Proposed Fix Attachment 270689 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/783162 New failing tests: imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html

Build Bot

Comment 6 2016-02-04 14:02:53 PST

Created attachment 270693 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5

Timothy Hatcher

Comment 7 2016-02-04 14:09:23 PST

Comment on attachment 270689 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270689&action=review > Source/WebInspectorUI/UserInterface/Images/LayoutInstrument.svg:3 > +<svg viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg"> Should standardize the other for these. I cleaned up all the existing icons and used this format: <svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 16 16"> Ditto for the rest of the SVGs.

Joseph Pecoraro

Comment 8 2016-02-04 14:15:16 PST

Created attachment 270694 [details] [PATCH] For Landing

WebKit Commit Bot

Comment 9 2016-02-04 15:13:50 PST

Comment on attachment 270694 [details] [PATCH] For Landing Clearing flags on attachment: 270694 Committed r196151: <http://trac.webkit.org/changeset/196151>

Joseph Pecoraro

Comment 10 2016-02-04 17:32:08 PST

Removed some more unused images in: <http://trac.webkit.org/changeset/196163>

Note You need to log in before you can comment on or make changes to this bug.