Bug 153860

Summary: [GTK] Scrollbars not correctly rendered in non GNOME environments
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, clopez, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mcatanzaro
Priority: P2 Keywords: Gtk, Regression
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2016-02-04 02:44:12 PST
I noticed this in a matchbox environment, where there's no gnome-setting-daemon running. The problem is only with the scrollbars, because we initialize the GtkSettings in RenderThemeGtk and notify the ScrollbarTheme when it changes, but ScrollbarTheme is created before RenderThemeGtk so we initialize the theme properties before the GtkSettings have been initialized. We could just let the ScrollbarTheme monitor the theme itself instead of relying on being notified by the WebCore layer.
Attachments
Patch (2.82 KB, patch)
2016-02-04 02:46 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-02-04 02:46:14 PST
Created attachment 270648 [details] Patch
Carlos Garcia Campos
Comment 2 2016-02-05 05:58:33 PST
Committed r196171: <http://trac.webkit.org/changeset/196171>
Note You need to log in before you can comment on or make changes to this bug.