Summary: | [iOS] Throw away linked code when navigating to a new page. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||
Component: | WebCore JavaScript | Assignee: | Andreas Kling <kling> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | barraclough, cdumez, commit-queue, japhet, keith_miller, kling, mark.lam, msaboff, saam | ||||||||||||
Priority: | P2 | Keywords: | Performance | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 153940 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Andreas Kling
2016-02-03 17:51:07 PST
Created attachment 270619 [details]
Patch
Comment on attachment 270619 [details] Patch Clearing flags on attachment: 270619 Committed r196104: <http://trac.webkit.org/changeset/196104> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 153940 Created attachment 270795 [details]
Patch for relanding
Let's try to re-land this with a fix: don't throw away code unless we're navigating away from an existing history item.
Or basically only do this if the navigation is PageCache-eligible.
Comment on attachment 270795 [details] Patch for relanding Clearing flags on attachment: 270795 Committed r196217: <http://trac.webkit.org/changeset/196217> All reviewed patches have been landed. Closing bug. Rolled out in <https://trac.webkit.org/changeset/202139> Created attachment 281556 [details]
Patch
Same thing again, but this time we only do it if we haven't navigated in the last 2 seconds.
This looks a bit cheesy at first sight, but I can't think of a simpler fix for the excessive work problem.
Created attachment 281557 [details]
Patch
Attachment 281557 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/MemoryPressureHandler.cpp:43: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 281557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=281557&action=review > Source/WebCore/platform/MemoryPressureHandler.cpp:167 > + const auto minimumTimeSinceNavigation = std::chrono::seconds(2); Could just say const auto minimumTimeSinceNavigation = 2s; Created attachment 281559 [details]
Patch for landing
Comment on attachment 281559 [details] Patch for landing Clearing flags on attachment: 281559 Committed r202166: <http://trac.webkit.org/changeset/202166> All reviewed patches have been landed. Closing bug. |