| Summary: | [GTK] Touch slider test fails due to assertion in webkitWebViewBaseTouchEvent() | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrien Plazas <aplazas> | ||||||||||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | berto, bugs-noreply, carlosg, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Adrien Plazas
2016-02-03 04:22:49 PST
Created attachment 272480 [details]
Remove gesture sequence from touch sequence set
This allows several non-passing tests to pass.
Some of the passing tests where expected not to pass on my machine, I don't know if that's good or bad:
- fast/events/touch/frame-hover-update.html
- fast/events/touch/touch-stale-node-crash.html
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Attachment 272480 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:961: Missing space before ( in if( [whitespace/parens] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 272481 [details]
Remove gesture sequence from touch sequence set
This allows several failing tests to pass.
Some of the passing tests where expected not to pass on my machine, I don't know if that's good or bad:
- fast/events/touch/frame-hover-update.html
- fast/events/touch/touch-stale-node-crash.html
Comment on attachment 272481 [details] Remove gesture sequence from touch sequence set View in context: https://bugs.webkit.org/attachment.cgi?id=272481&action=review You should remove the tests the pass now from the TestExpectations file. > Source/WebKit2/ChangeLog:9 > + Once a touch event sequence is identified as a gesture, remove it > + from the list of handled touch events. > + > + Reviewed by NOBODY (OOPS!). We normally add the description after the Reviewed by line. > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:962 > + if (priv->touchEvents.contains(sequence)) > + priv->touchEvents.remove(sequence); No need to check the sequence is in the map, remove() does nothing if not present. Comment on attachment 272481 [details] Remove gesture sequence from touch sequence set Attachment 272481 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/900062 New failing tests: storage/indexeddb/odd-strings-private.html Created attachment 272483 [details]
Archive of layout-test-results from ews117 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 272484 [details]
Remove gesture sequence from touch sequence set
Comment on attachment 272484 [details] Remove gesture sequence from touch sequence set View in context: https://bugs.webkit.org/attachment.cgi?id=272484&action=review No need to ask for review again once you got an r+. Upload the new patch for landing with the review comments addressed, the Reviewed by line already filled and only ask for commit-queue > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:962 > + if (priv->touchEvents.contains(sequence)) > + priv->touchEvents.remove(sequence); No need to check the sequence is in the map, remove() does nothing if not present. Created attachment 272485 [details]
Remove gesture sequence from touch sequence set
Created attachment 272487 [details]
Remove gesture sequence from touch sequence set
Carlos Garnacho is going to take a look at the patch too, I'll cq+ once he confirms it's ok. The patch indeed makes sense. In X11 this is not usually a problem since touch sequences are monotonically increasing, so there's little chances of collision. I guess this could be promptly seen in wayland since touch IDs are quickly reused there. Comment on attachment 272487 [details] Remove gesture sequence from touch sequence set Clearing flags on attachment: 272487 Committed r197351: <http://trac.webkit.org/changeset/197351> All reviewed patches have been landed. Closing bug. |