Bug 153826

Summary: [GStreamer] Performance problems with bigger video resolution in the webrtc media player
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adam.bergkvist, commit-queue, mrobinson, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 153541    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch alex: review+

Description Alejandro G. Castro 2016-02-03 02:13:52 PST 
We have a performance issue when the video resolution is bigger, there is a FIXME in the implementation file about this:

MediaPlayerPrivateGstreamerOwr.cpp (InternalLoad):
...
// FIXME: Remove hardcoded video dimensions when the rendering performance
...
g_object_set(m_videoRenderer.get(), "width", 640, "height", 480, nullptr);
...
Comment 1 Philippe Normand 2016-08-11 02:19:15 PDT 
Created attachment 285822 [details]
patch
Comment 2 WebKit Commit Bot 2016-08-11 02:20:20 PDT 
Attachment 285822 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:84:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Philippe Normand 2016-08-11 02:22:39 PDT 
Created attachment 285823 [details]
patch
Comment 4 Alejandro G. Castro 2016-08-11 02:32:21 PDT 
Comment on attachment 285823 [details]
patch

LGTM
Comment 5 Philippe Normand 2016-08-12 03:40:20 PDT 
Committed r204410: <http://trac.webkit.org/changeset/204410>