Summary: | Indent inline box test fails due to assertion in VisibleSelection::selectionFromContentsOfNode() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrien Plazas <aplazas> | ||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Adrien Plazas
2016-02-02 23:18:05 PST
Created attachment 270565 [details]
Check if the node can offer a position before trying to get one from it.
This doesn't look specific to GTK+, patch changes only cross platform code. Comment on attachment 270565 [details] Check if the node can offer a position before trying to get one from it. View in context: https://bugs.webkit.org/attachment.cgi?id=270565&action=review > Source/WebCore/ChangeLog:3 > + [GTK] Indent inline box test fails due to assertion in VisibleSelection::selectionFromContentsOfNode() So, please remove the [GTK] prefix from the changelog Created attachment 270848 [details]
Check if the node can offer a position before trying to get one from it.
Comment on attachment 270848 [details]
Check if the node can offer a position before trying to get one from it.
The change is small, the current code is obviously wrong, and no other reviewer has objected for several days, so r=me.
Comment on attachment 270848 [details] Check if the node can offer a position before trying to get one from it. Clearing flags on attachment: 270848 Committed r196249: <http://trac.webkit.org/changeset/196249> All reviewed patches have been landed. Closing bug. |