Bug 153823

Summary: [CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, kondapallykalyan, luiz, noam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+

Description Zan Dobersek 2016-02-02 22:39:32 PST
[CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes
Comment 1 Zan Dobersek 2016-02-03 00:03:24 PST
Created attachment 270559 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-02-03 00:23:15 PST
Comment on attachment 270559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270559&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:64
> +    TemporaryChange<bool> destructing(m_isDestructing, true);

Do we really need to make this temporal change? What's the point of setting back its original value if this is the destructor?
Comment 3 Zan Dobersek 2016-02-03 00:36:07 PST
Comment on attachment 270559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270559&action=review

>> Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:64
>> +    TemporaryChange<bool> destructing(m_isDestructing, true);
> 
> Do we really need to make this temporal change? What's the point of setting back its original value if this is the destructor?

Heh, noted.
Comment 4 Zan Dobersek 2016-02-03 00:42:02 PST
Committed r196056: <http://trac.webkit.org/changeset/196056>