Bug 153823

Summary:

[CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, kondapallykalyan, luiz, noam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cgarcia: review+

Zan Dobersek

Reported 2016-02-02 22:39:32 PST

[CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes

Attachments
Patch (4.65 KB, patch) 2016-02-03 00:03 PST, Zan Dobersek	cgarcia: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2016-02-03 00:03:24 PST

Created attachment 270559 [details] Patch

Carlos Garcia Campos

Comment 2 2016-02-03 00:23:15 PST

Comment on attachment 270559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270559&action=review > Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:64 > + TemporaryChange<bool> destructing(m_isDestructing, true); Do we really need to make this temporal change? What's the point of setting back its original value if this is the destructor?

Zan Dobersek

Comment 3 2016-02-03 00:36:07 PST

Comment on attachment 270559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270559&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:64 >> + TemporaryChange<bool> destructing(m_isDestructing, true); > > Do we really need to make this temporal change? What's the point of setting back its original value if this is the destructor? Heh, noted.

Zan Dobersek

Comment 4 2016-02-03 00:42:02 PST

Committed r196056: <http://trac.webkit.org/changeset/196056>

Note You need to log in before you can comment on or make changes to this bug.