Bug 153755

Summary: Move some SPI declarations into the appropriate SPI header
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, commit-queue, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2016-02-01 11:04:17 PST
Move some SPI declarations into the appropriate SPI header
Attachments
Patch (2.57 KB, patch)
2016-02-01 11:05 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2016-02-01 11:17 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (3.05 KB, patch)
2016-02-01 13:19 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-02-01 11:05:12 PST
Created attachment 270404 [details] Patch
Tim Horton
Comment 2 2016-02-01 11:17:03 PST
Created attachment 270406 [details] Patch
WebKit Commit Bot
Comment 3 2016-02-01 12:47:58 PST
Comment on attachment 270406 [details] Patch Rejecting attachment 270406 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 270406, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 195970 = af1351aae2f7a5668af4c1125b10410b9285cfc3 r195971 = 7d2af38e08d890e30643889ff2050a57f5c16bb9 r195975 = 8ff2985d9f167d0aa1602086cdf58cd6a371cdc3 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/769104
Tim Horton
Comment 4 2016-02-01 13:19:49 PST
Created attachment 270418 [details] Patch
WebKit Commit Bot
Comment 5 2016-02-01 14:07:11 PST
Comment on attachment 270418 [details] Patch Clearing flags on attachment: 270418 Committed r195979: <http://trac.webkit.org/changeset/195979>
WebKit Commit Bot
Comment 6 2016-02-01 14:07:14 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2016-02-03 03:37:24 PST
(In reply to comment #5) > Comment on attachment 270418 [details] > Patch > > Clearing flags on attachment: 270418 > > Committed r195979: <http://trac.webkit.org/changeset/195979> It broke the Apple Mac cmake build: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:33:10: fatal error: 'IOSurfaceSPI.h' file not found #include "IOSurfaceSPI.h" ^ [ 87%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CacheModel.cpp.o 1 error generated.
Csaba Osztrogonác
Comment 8 2016-02-03 03:39:48 PST
and the buildfix landed in https://trac.webkit.org/changeset/196064
Note You need to log in before you can comment on or make changes to this bug.