Snapshot surfaces are forever wired after being compressed

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

Snapshot surfaces are forever wired after being compressed

[Tim Horton]

Created attachment 270399 [details]
Patch

[Darin Adler]

Comment on attachment 270399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270399&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:42
>  CGContextRef CGIOSurfaceContextCreate(IOSurfaceRef, size_t, size_t, size_t, size_t, CGColorSpaceRef, CGBitmapInfo);
>  CGImageRef CGIOSurfaceContextCreateImage(CGContextRef);
>  CGImageRef CGIOSurfaceContextCreateImageReference(CGContextRef);

Why isn’t any of this in the SPI header?

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:45
> +const NSString *WebIOSurfaceAcceleratorUnwireSurfaceKey = @"UnwireSurface";

The const here is placed wrong. I think you want NSString * const.

There’s no reason to put this inside the extern "C".

[Tim Horton]

(In reply to comment #2)
> Comment on attachment 270399 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270399&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:42
> >  CGContextRef CGIOSurfaceContextCreate(IOSurfaceRef, size_t, size_t, size_t, size_t, CGColorSpaceRef, CGBitmapInfo);
> >  CGImageRef CGIOSurfaceContextCreateImage(CGContextRef);
> >  CGImageRef CGIOSurfaceContextCreateImageReference(CGContextRef);
> 
> Why isn’t any of this in the SPI header?

Good question.

> > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:45
> > +const NSString *WebIOSurfaceAcceleratorUnwireSurfaceKey = @"UnwireSurface";
> 
> The const here is placed wrong. I think you want NSString * const.
> 
> There’s no reason to put this inside the extern "C".

OK!

Thank you!

[Tim Horton]

Created attachment 270401 [details]
Patch

[Tim Horton]

Created attachment 270407 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 270407 [details]
Patch

Clearing flags on attachment: 270407

Committed r195975: <http://trac.webkit.org/changeset/195975>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.