Bug 153751

Summary: Snapshot surfaces are forever wired after being compressed
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2016-02-01 10:23:52 PST
Snapshot surfaces are forever wired after being compressed
Attachments
Patch (2.19 KB, patch)
2016-02-01 10:24 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.20 KB, patch)
2016-02-01 10:47 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.27 KB, patch)
2016-02-01 11:29 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2016-02-01 10:24:13 PST
Created attachment 270399 [details] Patch
Darin Adler
Comment 2 2016-02-01 10:25:49 PST
Comment on attachment 270399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270399&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:42 > CGContextRef CGIOSurfaceContextCreate(IOSurfaceRef, size_t, size_t, size_t, size_t, CGColorSpaceRef, CGBitmapInfo); > CGImageRef CGIOSurfaceContextCreateImage(CGContextRef); > CGImageRef CGIOSurfaceContextCreateImageReference(CGContextRef); Why isn’t any of this in the SPI header? > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:45 > +const NSString *WebIOSurfaceAcceleratorUnwireSurfaceKey = @"UnwireSurface"; The const here is placed wrong. I think you want NSString * const. There’s no reason to put this inside the extern "C".
Tim Horton
Comment 3 2016-02-01 10:28:13 PST
(In reply to comment #2) > Comment on attachment 270399 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270399&action=review > > > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:42 > > CGContextRef CGIOSurfaceContextCreate(IOSurfaceRef, size_t, size_t, size_t, size_t, CGColorSpaceRef, CGBitmapInfo); > > CGImageRef CGIOSurfaceContextCreateImage(CGContextRef); > > CGImageRef CGIOSurfaceContextCreateImageReference(CGContextRef); > > Why isn’t any of this in the SPI header? Good question. > > Source/WebCore/platform/graphics/cocoa/IOSurface.mm:45 > > +const NSString *WebIOSurfaceAcceleratorUnwireSurfaceKey = @"UnwireSurface"; > > The const here is placed wrong. I think you want NSString * const. > > There’s no reason to put this inside the extern "C". OK! Thank you!
Tim Horton
Comment 4 2016-02-01 10:47:30 PST
Created attachment 270401 [details] Patch
Tim Horton
Comment 5 2016-02-01 11:29:47 PST
Created attachment 270407 [details] Patch
WebKit Commit Bot
Comment 6 2016-02-01 12:47:17 PST
Comment on attachment 270407 [details] Patch Clearing flags on attachment: 270407 Committed r195975: <http://trac.webkit.org/changeset/195975>
WebKit Commit Bot
Comment 7 2016-02-01 12:47:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.