Bug 153743
Summary: | Content Blocker rules are not applied to Google when you use address bar to search | ||
---|---|---|---|
Product: | WebKit | Reporter: | Andrey Meshkov <am> |
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | achristensen, benjamin, mateen110 |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Mac | ||
OS: | OS X 10.11 |
Andrey Meshkov
Original issue:
https://github.com/AdguardTeam/AdguardBrowserExtension/issues/153
#### Steps to reproduce:
1. Register the following content blocker (should be enough to block most of google search ads ads):
[
{
"trigger": {
"url-filter": ".*"
},
"action": {
"type": "css-display-none",
"selector": "#taw, #rhs_block > #mbEnd, #tads.c, #tads, #mbEnd, .ads-ad"
}
}
]
2. First of all, navigate to google.com and check that ads are hidden.
3. Open a new tab.
4. Enter some popular commercial search query in the address bar ("buy iphone 6s gold" for instance).
5. Press "Enter".
#### Expected result:
Ads should be hidden
#### In fact:
Ads are not hidden.
More than this, ads are not hidden even if I refresh the page (or enter some other search query).
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Andrey Meshkov
Here is an easier way to see what's going on. Instead of hiding ads, let's hide the whole page.
New steps for reproducing the issue:
1. Disable all ad filters
2. Add one rule: { action: { type: 'css-display-none', selector: 'body' } }
This rule hides the whole page.
3. Enter "https://www.google.com/" and press enter
4. The page is hidden (that's expected)
5. Now open new tab and enter "buy iphone 6s" in the address bar and press "Enter"
Expected result:
Whole page is hidden
In fact:
Page is not hidden.
It is not hidden even after you refresh the page.
ttam110
+1
Andrey Meshkov
Seems to be fixed.