Bug 153697
| Summary: | [GTK] Some new CSP tests are failing with one-space difference in output | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, dbates, dpino, mcatanzaro |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=153776 | ||
Michael Catanzaro
The following layout tests have been failing for GTK since they were added in r195367:
http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html [ Failure ]
http/tests/security/contentSecurityPolicy/object-src-applet-archive.html [ Failure ]
http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase.html [ Failure ]
http/tests/security/contentSecurityPolicy/object-src-applet-code.html [ Failure ]
The only difference from the expected output is that there is one extra space character that doesn't exist on the other ports:
-This test passes if there is a console message saying the plugin was blocked. The test must be run manually; ContentShell doesn't support applet in DumpRenderTree mode. :(
+This test passes if there is a console message saying the plugin was blocked. The test must be run manually; ContentShell doesn't support applet in DumpRenderTree mode. :(
(Select those lines to note the whitespace difference at the end of the lines.)
I'm tempted to just add expected results with the space, but I have no clue where the space is coming from; it doesn't seem right. So I will instead mark these as failing for now.
Also, I'm not pleased that (a) this is a manual test outside of the ManualTests directory, and (b) there is no console message saying that the plugin was blocked even when running the test manually (at least in 2.10.4; maybe that was one of the recent fixes?).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Daniel Bates
We should just remove the tests for now. I inadvertently imported these manual tests from Blink. We need to convert this tests to DumpRenderTree/WebKitTestRunner tests (if possible) or move them to the top-level ManualTests directory.
Daniel Bates
(In reply to comment #1)
> We should just remove the tests for now. I inadvertently imported these
> manual tests from Blink. We need to convert this tests to
> DumpRenderTree/WebKitTestRunner tests (if possible) or move them to the
> top-level ManualTests directory.
Filed bug #153776 to convert these tests to DumpRenderTree/WebKitTestRunner tests.
Diego Pino
Tests are passing since r267640.