Bug 153659

Summary: Web Inspector: Duplicate tab-types being saved to setting, causing duplicate tabs to be opened
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-01-29 11:16:22 PST
* SUMMARY Duplicate tab-types being saved to setting, causing duplicate tabs to be opened.
Attachments
[PATCH] Proposed Fix (2.75 KB, patch)
2016-01-29 11:19 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-01-29 11:16:46 PST
<rdar://problem/24413157>
Radar WebKit Bug Importer
Comment 2 2016-01-29 11:16:50 PST
<rdar://problem/24413426>
Joseph Pecoraro
Comment 3 2016-01-29 11:19:22 PST
Created attachment 270228 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 4 2016-01-29 11:45:08 PST
Comment on attachment 270228 [details] [PATCH] Proposed Fix r=me I thought we already de-duplicated when storing. I vaguely remember running into this issue and fixing it somehow when working in this part of the code. Guess it didn't work for all cases.
WebKit Commit Bot
Comment 5 2016-01-29 12:35:38 PST
Comment on attachment 270228 [details] [PATCH] Proposed Fix Clearing flags on attachment: 270228 Committed r195835: <http://trac.webkit.org/changeset/195835>
WebKit Commit Bot
Comment 6 2016-01-29 12:35:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.