| Summary: | Replace CaseFoldingHash with ASCIICaseInsensitiveHash | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | andersca, ap, benjamin, buildbot, cdumez, commit-queue, kling, koivisto, ossy, rniwa, ryanhaddad, sam | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 153723 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Darin Adler
2016-01-28 21:31:25 PST
Created attachment 270182 [details]
Patch
Comment on attachment 270182 [details] Patch Attachment 270182 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/753881 Number of test failures exceeded the failure limit. Created attachment 270187 [details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270182 [details] Patch Attachment 270182 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/753863 Number of test failures exceeded the failure limit. Created attachment 270188 [details]
Archive of layout-test-results from ews114 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 270182 [details] Patch Attachment 270182 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/753939 Number of test failures exceeded the failure limit. Created attachment 270189 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 270313 [details]
Patch
Accidentally deleted a line of code in the previous patch which was why the tests were failing. I expect this to one to do better. Yes, everything passed on EWS as I expected. Someone available to review? Comment on attachment 270313 [details]
Patch
r=me.
Committed r195911: <http://trac.webkit.org/changeset/195911> This appears to have caused very frequent (but very random) assertion failures on tests. Will roll out, as tests are fairly flaky now, so I'd like to get rid of all the noise ASAP. https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r195913%20(2573)/results.html https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r195911%20(2572)/results.html Re-opened since this is blocked by bug 153723 I’m going to figure out what caused the crash and re-land. Committed r195928: <http://trac.webkit.org/changeset/195928> |