Bug 153639

Summary:

Replace CaseFoldingHash with ASCIICaseInsensitiveHash

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, ap, benjamin, buildbot, cdumez, commit-queue, kling, koivisto, ossy, rniwa, ryanhaddad, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

153723

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews114 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Patch	fpizlo: review+

Darin Adler

Reported 2016-01-28 21:31:25 PST

Replace CaseFoldingHash with ASCIICaseInsensitiveHash

Attachments
Patch (48.59 KB, patch) 2016-01-28 21:51 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (405.30 KB, application/zip) 2016-01-28 22:43 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (298.80 KB, application/zip) 2016-01-28 22:45 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (784.83 KB, application/zip) 2016-01-28 23:09 PST, Build Bot	no flags	Details
Patch (54.54 KB, patch) 2016-01-30 11:20 PST, Darin Adler	fpizlo: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2016-01-28 21:51:38 PST

Created attachment 270182 [details] Patch

Build Bot

Comment 2 2016-01-28 22:43:36 PST

Comment on attachment 270182 [details] Patch Attachment 270182 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/753881 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2016-01-28 22:43:39 PST

Created attachment 270187 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 4 2016-01-28 22:45:00 PST

Comment on attachment 270182 [details] Patch Attachment 270182 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/753863 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2016-01-28 22:45:03 PST

Created attachment 270188 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-01-28 23:09:38 PST

Comment on attachment 270182 [details] Patch Attachment 270182 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/753939 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2016-01-28 23:09:41 PST

Created attachment 270189 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Darin Adler

Comment 8 2016-01-30 11:20:19 PST

Created attachment 270313 [details] Patch

Darin Adler

Comment 9 2016-01-30 11:21:17 PST

Accidentally deleted a line of code in the previous patch which was why the tests were failing. I expect this to one to do better.

Darin Adler

Comment 10 2016-01-30 13:20:27 PST

Yes, everything passed on EWS as I expected. Someone available to review?

Filip Pizlo

Comment 11 2016-01-30 13:52:44 PST

Comment on attachment 270313 [details] Patch r=me.