Bug 153605

Summary:

[B3][Win64] Compile fixes.

Product:

WebKit

Reporter:

peavo

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, fpizlo, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	fpizlo: review+

Description peavo 2016-01-28 11:20:47 PST

This patch fixes the rest of the compile errors on Win64 when compiling with the following defines:

#define HAVE_LLVM 1
#define ENABLE_FTL_JIT 1
#define ENABLE_B3_JIT 1
#define FTL_USES_B3 1

Comment 1 peavo 2016-01-28 11:27:46 PST

Created attachment 270130 [details]
Patch

Comment 2 Alex Christensen 2016-01-28 11:30:16 PST

What happened to not using LLVM on Windows?

Comment 3 peavo 2016-01-28 11:35:59 PST

(In reply to comment #2)
> What happened to not using LLVM on Windows?

LLVM is not used, but it seems HAVE_LLVM currently needs to defined to avoid compile errors.

Comment 4 peavo 2016-01-29 06:21:35 PST

Created attachment 270205 [details]
Patch

Comment 5 Build Bot 2016-01-29 07:05:04 PST

Comment on attachment 270205 [details]
Patch

Attachment 270205 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/755467

Number of test failures exceeded the failure limit.

Comment 6 Build Bot 2016-01-29 07:05:07 PST

Created attachment 270207 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 7 Build Bot 2016-01-29 07:08:46 PST

Comment on attachment 270205 [details]
Patch

Attachment 270205 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/755477

Number of test failures exceeded the failure limit.

Comment 8 Build Bot 2016-01-29 07:08:50 PST

Created attachment 270208 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

Comment 9 Build Bot 2016-01-29 07:10:42 PST

Comment on attachment 270205 [details]
Patch

Attachment 270205 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/755461

Number of test failures exceeded the failure limit.

Comment 10 Build Bot 2016-01-29 07:10:46 PST

Created attachment 270209 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 11 peavo 2016-01-29 07:22:14 PST

Created attachment 270211 [details]
Patch

Comment 12 peavo 2016-02-02 08:42:18 PST

(In reply to comment #11)
> Created attachment 270211 [details]
> Patch

I removed the LLVM specific stuff in this patch :)

Comment 13 peavo 2016-02-02 10:31:20 PST

Thanks for reviewing :)

Comment 14 peavo 2016-02-02 11:10:35 PST

Committed r196019: <http://trac.webkit.org/changeset/196019>