Bug 153597 – REGRESSION(r195743): [GTK] Build broken

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

Revision r195743 <https://trac.webkit.org/changeset/195743> broke the GTK+ build:

Building CXX object Tools/WebKitTestRunner/CMakeFiles/TestRunnerInjectedBundle.dir/InjectedBundle/atk/AccessibilityUIElementAtk.cpp.o
FAILED: /usr/lib/ccache/clang++   -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DDATA_DIR=\"share\" -DFONTS_CONF_DIR=\"/home/clopez/webkit/webkit/Tools/WebKitTestRunner/gtk/fonts\" -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DTOP_LEVEL_DIR=\"/home/clopez/webkit/webkit\" -DTestRunnerInjectedBundle_EXPORTS -DUSER_AGENT_GTK_MAJOR_VERSION=\"602\" -DUSER_AGENT_GTK_MINOR_VERSION=\"1\" -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -std=c++11 -fcolor-diagnostics -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti -fPIC -I../../Tools/WebKitTestRunner -I../../Tools/WebKitTestRunner/InjectedBundle -I../../Tools/WebKitTestRunner/InjectedBundle/Bindings -I../../Tools/WebKitTestRunner/InjectedBundle/atk -I../../Tools/WebKitTestRunner/UIScriptContext -I../../Tools/WebKitTestRunner/UIScriptContext/Bindings -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/ForwardingHeaders -IDerivedSources/JavaScriptCore -I../../Source/WebCore/editing -I../../Source/WebCore/platform -I../../Source/WebCore/platform/graphics -I../../Source/WebCore/platform/graphics/harfbuzz -I../../Source/WebCore/platform/graphics/harfbuzz/ng -I../../Source/WebCore/platform/network -I../../Source/WebCore/platform/text -I../../Source/WebCore/testing/js -I../../Source/WebKit2/Platform/IPC -I../../Source/WebKit2/Shared -I../../Source/WebKit2/Shared/API/c -I../../Source/WebKit2/Shared/Plugins -I../../Source/WebKit2/UIProcess -I../../Source/WebKit2/UIProcess/API/C/soup -I../../Source/WebKit2/WebProcess/InjectedBundle -I../../Source/WebKit2/WebProcess/InjectedBundle/API/c -I../../Source/WTF -IDerivedSources/InjectedBundle -IDerivedSources/UIScriptContext -I. -I../../Source -IDerivedSources/ForwardingHeaders -I../../Source/WTF/wtf/glib -isystem ../DependenciesGTK/Root/include/libsoup-2.4 -isystem ../DependenciesGTK/Root/include/atk-1.0 -isystem ../DependenciesGTK/Root/include/cairo -isystem ../DependenciesGTK/Root/include/gtk-3.0 -isystem ../DependenciesGTK/Root/include/at-spi2-atk/2.0 -isystem ../DependenciesGTK/Root/include/gio-unix-2.0 -isystem ../DependenciesGTK/Root/include/pango-1.0 -isystem ../DependenciesGTK/Root/include/harfbuzz -isystem ../DependenciesGTK/Root/include/pixman-1 -isystem ../DependenciesGTK/Root/include/freetype2 -isystem ../DependenciesGTK/Root/include/libxml2 -isystem ../DependenciesGTK/Root/include/gdk-pixbuf-2.0 -isystem ../DependenciesGTK/Root/include/glib-2.0 -isystem ../DependenciesGTK/Root/lib/glib-2.0/include -isystem /usr/include/libdrm -isystem /usr/include/libpng12 -MMD -MT Tools/WebKitTestRunner/CMakeFiles/TestRunnerInjectedBundle.dir/InjectedBundle/atk/AccessibilityUIElementAtk.cpp.o -MF Tools/WebKitTestRunner/CMakeFiles/TestRunnerInjectedBundle.dir/InjectedBundle/atk/AccessibilityUIElementAtk.cpp.o.d -o Tools/WebKitTestRunner/CMakeFiles/TestRunnerInjectedBundle.dir/InjectedBundle/atk/AccessibilityUIElementAtk.cpp.o -c ../../Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
../../Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1353:12: error: no matching function for call to 'equalLettersIgnoringASCIICase'
    return equalLettersIgnoringASCIICase(actionName, "press") || equalLettersIgnoringASCIICase(actionName, "jump");
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Source/WTF/wtf/text/StringCommon.h:577:50: note: candidate function template not viable: requires 3 arguments, but 2 were provided
template<typename CharacterType> __inline__ bool equalLettersIgnoringASCIICase(const CharacterType* characters, const char* lowercaseLetters, unsigned length)
                                                 ^
../../Source/WTF/wtf/text/StringCommon.h:586:83: note: candidate function template not viable: requires 3 arguments, but 2 were provided
template<typename CharacterType, unsigned lowercaseLettersLength> __inline__ bool equalLettersIgnoringASCIICase(const CharacterType* characters, unsigned charactersLength, const char (&lowercaseLetters)[lowercaseLettersLength])
                                                                                  ^
../../Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1353:66: error: no matching function for call to 'equalLettersIgnoringASCIICase'
    return equalLettersIgnoringASCIICase(actionName, "press") || equalLettersIgnoringASCIICase(actionName, "jump");
                                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Source/WTF/wtf/text/StringCommon.h:577:50: note: candidate function template not viable: requires 3 arguments, but 2 were provided
template<typename CharacterType> __inline__ bool equalLettersIgnoringASCIICase(const CharacterType* characters, const char* lowercaseLetters, unsigned length)
                                                 ^
../../Source/WTF/wtf/text/StringCommon.h:586:83: note: candidate function template not viable: requires 3 arguments, but 2 were provided
template<typename CharacterType, unsigned lowercaseLettersLength> __inline__ bool equalLettersIgnoringASCIICase(const CharacterType* characters, unsigned charactersLength, const char (&lowercaseLetters)[lowercaseLettersLength])
                                                                                  ^
2 errors generated.

[Darin Adler]

(In reply to comment #0)
> Revision r195743 <https://trac.webkit.org/changeset/195743> broke the GTK+
> build:

Strange, it worked on EWS.

> ../../Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.
> cpp:1353:12: error: no matching function for call to
> 'equalLettersIgnoringASCIICase'
>     return equalLettersIgnoringASCIICase(actionName, "press") ||
> equalLettersIgnoringASCIICase(actionName, "jump");
>            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I suggest considering just using strcasecmp here instead of using functions from WTF since this is only test code anyway and it doesn't seem like a WebKit-specific thing to compare one const char* to another.

Looks like Ossy fixed this in http://trac.webkit.org/changeset/195768