Bug 153561

Summary: Modern IDB: Fix many Index tests
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153021    
Attachments:
Description Flags
Patch v1
none
Patch v1 achristensen: review+

Brady Eidson
Reported 2016-01-27 14:47:02 PST
Modern IDB: Fix many Index tests 1 - Getting an Index record could return null instead of undefined 2 - We almost always entered the exact same index record into the database twice
Attachments
Patch v1 (10.21 KB, patch)
2016-01-27 14:55 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch v1 (10.21 KB, patch)
2016-01-27 14:58 PST, Brady Eidson 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-01-27 14:55:35 PST
Created attachment 270049 [details] Patch v1
Brady Eidson
Comment 2 2016-01-27 14:58:09 PST
Created attachment 270050 [details] Patch v1
WebKit Commit Bot
Comment 3 2016-01-27 14:59:24 PST
Attachment 270050 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1242: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 4 2016-01-27 15:00:43 PST
Comment on attachment 270050 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=270050&action=review r=me > Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1240 > + if (cursor->didComplete()) { { not necessary.
Brady Eidson
Comment 5 2016-01-27 15:04:02 PST
http://trac.webkit.org/changeset/195697
Note You need to log in before you can comment on or make changes to this bug.