Bug 153561

Summary: Modern IDB: Fix many Index tests
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153021    
Attachments:
Description Flags
Patch v1
none
Patch v1 achristensen: review+

Description Brady Eidson 2016-01-27 14:47:02 PST 
Modern IDB: Fix many Index tests

1 - Getting an Index record could return null instead of undefined
2 - We almost always entered the exact same index record into the database twice
Comment 1 Brady Eidson 2016-01-27 14:55:35 PST 
Created attachment 270049 [details]
Patch v1
Comment 2 Brady Eidson 2016-01-27 14:58:09 PST 
Created attachment 270050 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-01-27 14:59:24 PST 
Attachment 270050 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1242:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2016-01-27 15:00:43 PST 
Comment on attachment 270050 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=270050&action=review

r=me

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1240
> +    if (cursor->didComplete()) {

{ not necessary.
Comment 5 Brady Eidson 2016-01-27 15:04:02 PST 
http://trac.webkit.org/changeset/195697