Bug 153548

Summary: Modern IDB: SQLite backend doesn't update index records as object records are added
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117, 153021    
Attachments:
Description Flags
Patch v1
achristensen: review+, achristensen: commit-queue-
Patch for landing none

Description Brady Eidson 2016-01-27 09:34:36 PST
Modern IDB: SQLite backend doesn't update index records as object records are added
Comment 1 Brady Eidson 2016-01-27 12:25:31 PST
Created attachment 270022 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-01-27 12:27:48 PST
Attachment 270022 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h:96:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2016-01-27 12:47:11 PST
Comment on attachment 270022 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=270022&action=review

r=me

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:840
> +        IDBError error = uncheckedPutIndexRecord(info.objectStoreIdentifier(), info.identifier(), key, indexKey.asOneKey());

auto?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:851
> +        bool hasRecord;
> +        IDBError error;

The scope of these is strange.

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:862
> +        IDBError error = uncheckedPutIndexRecord(info.objectStoreIdentifier(), info.identifier(), key, indexKey);

auto?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1077
> +    auto indexes = info.indexMap();

I don't think this needs its own variable name if we are only going to iterate its values.
Comment 4 Brady Eidson 2016-01-27 13:10:46 PST
Created attachment 270032 [details]
Patch for landing

I think the scoping on those makes sense.

Fixed everything else.
Comment 5 WebKit Commit Bot 2016-01-27 13:57:31 PST
Comment on attachment 270032 [details]
Patch for landing

Clearing flags on attachment: 270032

Committed r195689: <http://trac.webkit.org/changeset/195689>
Comment 6 WebKit Commit Bot 2016-01-27 13:57:34 PST
All reviewed patches have been landed.  Closing bug.