Bug 153548 – Modern IDB: SQLite backend doesn't update index records as object records are added

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Brady Eidson]

Modern IDB: SQLite backend doesn't update index records as object records are added

[Brady Eidson]

Created attachment 270022 [details]
Patch v1

[WebKit Commit Bot]

Attachment 270022 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.h:96:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 270022 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=270022&action=review

r=me

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:840
> +        IDBError error = uncheckedPutIndexRecord(info.objectStoreIdentifier(), info.identifier(), key, indexKey.asOneKey());

auto?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:851
> +        bool hasRecord;
> +        IDBError error;

The scope of these is strange.

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:862
> +        IDBError error = uncheckedPutIndexRecord(info.objectStoreIdentifier(), info.identifier(), key, indexKey);

auto?

> Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:1077
> +    auto indexes = info.indexMap();

I don't think this needs its own variable name if we are only going to iterate its values.

[Brady Eidson]

Created attachment 270032 [details]
Patch for landing

I think the scoping on those makes sense.

Fixed everything else.

[WebKit Commit Bot]

Comment on attachment 270032 [details]
Patch for landing

Clearing flags on attachment: 270032

Committed r195689: <http://trac.webkit.org/changeset/195689>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.