Bug 153527

Summary:

Move ContentSecurityPolicy.{cpp, h} to its own directory

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebCore Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Daniel Bates

Reported 2016-01-26 17:44:26 PST

We should move ContentSecurityPolicy.{cpp, h} to its own directory, say Source/WebCore/page/csp, so as to group Content Security Policy machinery in the source tree. Among other things, this will allow us to extract the policy parsing support classes (e.g. CSPDirectiveList) into their own files to improve the hackability of this code. Organizing all such CSP machinery into its own directory helps make relate all of the individual files by consolidating them under a single directory.

Attachments
Patch (166.78 KB, patch) 2016-01-26 17:48 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (166.80 KB, patch) 2016-01-26 17:51 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (167.07 KB, patch) 2016-01-26 18:13 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (168.32 KB, patch) 2016-01-26 18:31 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-01-26 17:45:03 PST

<rdar://problem/24359892>

Daniel Bates

Comment 2 2016-01-26 17:48:55 PST

Created attachment 269960 [details] Patch

Daniel Bates

Comment 3 2016-01-26 17:51:51 PST

Created attachment 269961 [details] Patch

WebKit Commit Bot

Comment 4 2016-01-26 17:54:08 PST

Attachment 269961 [details] did not pass style-queue: ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:389: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:397: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:495: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1016: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1017: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1020: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1024: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1025: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1028: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1032: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1033: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1036: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1039: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1040: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1043: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1046: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1047: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1050: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1055: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1056: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1059: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1064: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1065: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1068: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1071: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1072: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1075: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1078: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1079: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1082: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1085: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1086: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1089: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1092: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1093: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1096: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1099: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1103: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1113: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1116: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1119: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1120: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1124: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 47 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 5 2016-01-26 18:13:35 PST

Created attachment 269964 [details] Patch Add Source/WebCore/page/csp to the list of include directories in CMakeLists.txt to try to fix GTK and EFL EWS bots.

WebKit Commit Bot

Comment 6 2016-01-26 18:15:58 PST

Attachment 269964 [details] did not pass style-queue: ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:389: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:397: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:495: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1016: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1017: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1020: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1024: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1025: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1028: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1032: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1033: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1036: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1039: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1040: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1043: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1046: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1047: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1050: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1055: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1056: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1059: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1064: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1065: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1068: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1071: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1072: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1075: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1078: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1079: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1082: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1085: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1086: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1089: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1092: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1093: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1096: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1099: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1103: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1113: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1116: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1119: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1120: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1124: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 47 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 7 2016-01-26 18:31:37 PST

Created attachment 269966 [details] Patch Add ${WEBCORE_DIR}/page/csp to the list of WebKit2 include directories in Source/WebKit2/CMakeLists.txt.

WebKit Commit Bot

Comment 8 2016-01-26 18:32:53 PST

Attachment 269966 [details] did not pass style-queue: ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:389: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:397: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:495: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1016: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1017: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1020: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1024: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1025: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1028: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1032: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1033: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1036: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1039: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1040: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1043: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1046: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1047: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1050: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1055: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1056: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1059: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1064: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1065: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1068: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1071: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1072: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1075: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1078: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1079: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1082: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1085: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1086: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1089: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1092: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1093: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1096: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1099: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1103: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1112: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1113: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1116: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1119: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1120: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1124: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.cpp:1126: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/csp/ContentSecurityPolicy.h:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 47 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 9 2016-01-27 17:08:10 PST

Comment on attachment 269966 [details] Patch Clearing flags on attachment: 269966 Committed r195711: <http://trac.webkit.org/changeset/195711>

Daniel Bates

Comment 10 2016-01-27 17:08:14 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.