Summary: | fast/history/page-cache-webdatabase-no-transaction-db.html flakily crashes | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | Platform | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, ap, beidson, buildbot, commit-queue, dbates, kling, koivisto, rniwa | ||||||||||
Priority: | P1 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2016-01-26 16:36:16 PST
I think the issue is that DatabaseThread::hasPendingDatabaseActivity() is called from the main thread and accesses m_openDatabaseSet which is only meant to be accessed from the database thread. As a result, the database thread can alter m_openDatabaseSet while the main thread is iterating over it. Committed r195638: <http://trac.webkit.org/changeset/195638> Test temporarily skipped in <http://trac.webkit.org/changeset/195638> Reopening as I did not land a fix yet. Created attachment 269952 [details]
Patch
Comment on attachment 269952 [details]
Patch
r=me
Comment on attachment 269952 [details] Patch Attachment 269952 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/743443 New failing tests: fast/history/page-cache-webdatabase-no-transaction-db.html Created attachment 269962 [details]
Archive of layout-test-results from ews115 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 269952 [details] Patch Attachment 269952 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/743589 New failing tests: fast/history/page-cache-webdatabase-no-transaction-db.html Created attachment 269965 [details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 269969 [details]
Patch
Comment on attachment 269969 [details] Patch Clearing flags on attachment: 269969 Committed r195652: <http://trac.webkit.org/changeset/195652> All reviewed patches have been landed. Closing bug. |