| Summary: | Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> | ||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, mcatanzaro, zan | ||||
| Priority: | P2 | ||||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 269887 [details]
Patch
Comment on attachment 269887 [details] Patch Clearing flags on attachment: 269887 Committed r195601: <http://trac.webkit.org/changeset/195601> All reviewed patches have been landed. Closing bug. |
Build with ENABLE_DEVICE_ORIENTATION is broken on non-iOS platforms: /WebKit/Source/WebCore/history/PageCache.cpp: In function ‘bool WebCore::canCachePage(WebCore::Page&)’: /WebKit/Source/WebCore/history/PageCache.cpp:201:48: error: no matching function for call to ‘WebCore::DeviceMotionController::isActiveAt(WebCore::Page&)’ if (DeviceMotionController::isActiveAt(page)) { ^ In file included from /WebKit/Source/WebCore/history/PageCache.cpp:34:0: /WebKit/Source/WebCore/dom/DeviceMotionController.h:59:17: note: candidate: static bool WebCore::DeviceMotionController::isActiveAt(WebCore::Page*) static bool isActiveAt(Page*); ^ /WebKit/Source/WebCore/dom/DeviceMotionController.h:59:17: note: no known conversion for argument 1 from ‘WebCore::Page’ to ‘WebCore::Page*’ /WebKit/Source/WebCore/history/PageCache.cpp:206:53: error: no matching function for call to ‘WebCore::DeviceOrientationController::isActiveAt(WebCore::Page&)’ if (DeviceOrientationController::isActiveAt(page)) { ^ In file included from /WebKit/Source/WebCore/history/PageCache.cpp:35:0: /WebKit/Source/WebCore/dom/DeviceOrientationController.h:61:17: note: candidate: static bool WebCore::DeviceOrientationController::isActiveAt(WebCore::Page*) static bool isActiveAt(Page*); ^ /WebKit/Source/WebCore/dom/DeviceOrientationController.h:61:17: note: no known conversion for argument 1 from ‘WebCore::Page’ to ‘WebCore::Page*’ This has been broken since r178702, which changed the Page argument from a pointer to a reference in logCanCachePageDecision().