Bug 15348
| Summary: | DOM Inspector hits exception when inspecting SVG | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | Keywords: | HasReduction |
| Priority: | P2 | ||
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| URL: | http://www.croczilla.com/svg/samples/butterfly/butterfly.svg | ||
| Bug Depends on: | 15422 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
DOM Inspector hits exception when inspecting SVG
(event handler):Null value
1. Inspect the path element (click on the orange or black part of the butterfly.
2. click on the "svg" "tab" at the bottom of the source display (5-sided figure, square with attached triangle)
3. click on the "path" "tab" at the bottom of the source dispaly:
4. you'll see this exception:
(event handler):Null value
I assume this is actually a bug in the JS bindings for SVGElement and not a bug in the inspector, but it could be either...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I cant seem to get Drosera to stop at the event handler null value. However, when I run Drosera I seem to get these additional logs in my console:
Unsafe JavaScript attempt to access frame with URL http://www.croczilla.com/svg/samples/butterfly/butterfly.svg from frame with URL file:///Stuff/Users/eric/Projects/build/Debug/WebCore.framework/Resources/inspector/inspector.html. Domains must match.
It seems strange to me that those only started after I launched Drosera, but perhaps I just missed them before.
Eric Seidel (no email)
Turns out that the line having trouble was:
if (!priorityUsed && style.getPropertyPriority(name).length)
style.getPropertyPriority(name) was returning null, because name was null.
Instead of fixing the JS, I implemented getComputedStyle for SVG, which stopped "name" from being null (at least for now). This isn't a full fix, but it solved my issue. If someone would like to make this hunk of inspector JS more robust, be my guess. I wasn't exactly sure what the "correct" behavior was when "name" was null.
The security exceptions are covered by:
http://bugs.webkit.org/show_bug.cgi?id=15419
Eric Seidel (no email)
Now that bug 15422 is solved, it is not absolutely necessary to change this JS. But I leave that up to ya'll inspector folks to decide. If so, just close the bug.
Timothy Hatcher
I think this can be closed since it no longer happens.