| Summary: | Web Inspector: Include SamplingProfiler's expression-level data for stack frames in the protocol | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <sbarati> | ||||||||||||
| Component: | Web Inspector | Assignee: | Saam Barati <sbarati> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bburg, buildbot, commit-queue, graouts, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, rniwa, timothy, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | 152629 | ||||||||||||||
| Bug Blocks: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Saam Barati
2016-01-25 15:21:52 PST
Created attachment 270696 [details]
patch
Comment on attachment 270696 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=270696&action=review r=me, but address renames > Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json:20 > + "id": "Location", Location is getting to be a heavily overloaded term. I think "ExpressionLocation" would be better. > Source/JavaScriptCore/inspector/protocol/ScriptProfiler.json:24 > + { "name": "lineNumber", "type": "integer" }, > + { "name": "columnNumber", "type": "integer" } Perhaps we should shorten these to "line" and "column" like ScriptProfiler.StackFrame (below). Whatever we choose should be consistent. I think short is fine, especially for objects like this which will show many many times. > LayoutTests/inspector/sampling-profiler/expression-location-info.html:49 > + let lineNumber = parseInt(lineColumnHashedString.split(":")[0]); > + let columnNumber = parseInt(lineColumnHashedString.split(":")[1]); Avoid doing the split twice. Up to you if you want to do the map or just pull them out individually. let [lineNumber, columnNumber] = lineColumnHashedString.split(":").map(Number); Comment on attachment 270696 [details] patch Attachment 270696 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/783383 New failing tests: inspector/sampling-profiler/call-frame-with-dom-functions.html Created attachment 270698 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 270767 [details]
patch for landing.
going to let EWS run tests
Comment on attachment 270767 [details] patch for landing. Attachment 270767 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/787840 New failing tests: inspector/sampling-profiler/expression-location-info.html Created attachment 270772 [details]
Archive of layout-test-results from ews103 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 270773 [details]
patch for landing.
lets give EWS another try.
landed in: http://trac.webkit.org/changeset/196193 |