Summary: | Many SVG tests "fail" due to changed text color dumping (after feature brach rebase) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | oliver, zimmermann | ||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2007-10-02 08:33:05 PDT
Created attachment 16504 [details]
attempted (sorta) fix
Yes, I updated all tests to not dump text colors at all in feature-branch. It's definately better than dumping invalid colors (as previously, as you said, the paint servers mutated color() when painting text - I changed that). I haven't checked the attached patch for correctness, as I'm really busy learning atm. Next week I can comment :-) Greetings, Niko How many failures are left are this change? I suggest we just remove the "color()" call, or apply my patch, and rebase. My patch should probably be changed to label the colors its dumping. Such as "fillColor=" instead of "color=" How many tests still failed after this? Lots. A different subset of the SVG tests. I should note, that if we're going to apply this patch, the "else if"s should just turn into ifs. And the color dumps should possibly be re-ordered. I'm not sure that dumping solid colors for text is very useful though (especially since this patch doesn't seem to catch all cases anyway. Fixed in fb svn. |