Summary: | [B3] Fix control reaches end of non-void function GCC warning after r195139 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | JavaScriptCore | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, keith_miller, mark.lam, mcatanzaro, msaboff, saam | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 152952 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2016-01-25 09:22:09 PST
Created attachment 269755 [details]
Patch
(In reply to comment #0) > ( Since https://trac.webkit.org/changeset/194858 we use ASSERT_NOT_REACHED() > to be able to catch possible bugs in debug mode. And this warnings are > suppressed in release mode not to cause performance slowdown. ) Oh, I didn't know that; I've been using RELEASE_ASSERT_NOT_REACHED() for this. Comment on attachment 269755 [details] Patch Clearing flags on attachment: 269755 Committed r195640: <http://trac.webkit.org/changeset/195640> All reviewed patches have been landed. Closing bug. |