Bug 153412

Summary: Web Inspector: Navigation bar in sidebars should always fit on a single line
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
[Animated GIF] Bug
none
Patch none

Nikita Vasilyev
Reported 2016-01-24 17:13:06 PST
Created attachment 269708 [details] [Animated GIF] Bug See the attached GIF.
Attachments
[Animated GIF] Bug (560.24 KB, image/gif)
2016-01-24 17:13 PST, Nikita Vasilyev 		no flags
Details
[Animated GIF] Bug (172.47 KB, image/gif)
2016-01-30 22:32 PST, Nikita Vasilyev 		no flags
Details
Patch (1.60 KB, patch)
2016-02-05 12:47 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-24 17:13:27 PST
<rdar://problem/24318706>
Matt Baker
Comment 2 2016-01-24 17:34:56 PST
Didn't Devin fix this for all sidebars? Since we're removing this sidebar in the Timelines UI redesign, I don't think we should invest any time fixing it, if the issue is specific to the TimelineSidebarPanel.
Nikita Vasilyev
Comment 3 2016-01-30 22:32:57 PST
Created attachment 270339 [details] [Animated GIF] Bug (In reply to comment #2) > Didn't Devin fix this for all sidebars? ... What was the bug URL? Styles sidebar and debugger sidebar (with probes enabled) are both affected. I can't reproduce it on Safari on OS X 10.11.3, so it's a regression.
Timothy Hatcher
Comment 4 2016-02-01 12:37:21 PST
Devin's fix was bug 152473.
Timothy Hatcher
Comment 5 2016-02-01 12:39:11 PST
From the animated GIF, it seems like there is contention between the minimum sidebar size and the maximum size. I suspect the maximum is smaller than the minimum, causing it to shrink when it is suppose to resize wider.
Devin Rousso
Comment 6 2016-02-02 21:59:58 PST
I have a bunch of classwork to finish up for next week, but I will take a look at this over the weekend.
Devin Rousso
Comment 7 2016-02-05 12:47:00 PST
Created attachment 270761 [details] Patch
WebKit Commit Bot
Comment 8 2016-02-05 13:38:47 PST
Comment on attachment 270761 [details] Patch Clearing flags on attachment: 270761 Committed r196187: <http://trac.webkit.org/changeset/196187>
WebKit Commit Bot
Comment 9 2016-02-05 13:38:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.