Summary: | Web Inspector: Navigation bar in sidebars should always fit on a single line | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Didn't Devin fix this for all sidebars? Since we're removing this sidebar in the Timelines UI redesign, I don't think we should invest any time fixing it, if the issue is specific to the TimelineSidebarPanel. Created attachment 270339 [details] [Animated GIF] Bug (In reply to comment #2) > Didn't Devin fix this for all sidebars? ... What was the bug URL? Styles sidebar and debugger sidebar (with probes enabled) are both affected. I can't reproduce it on Safari on OS X 10.11.3, so it's a regression. Devin's fix was bug 152473. From the animated GIF, it seems like there is contention between the minimum sidebar size and the maximum size. I suspect the maximum is smaller than the minimum, causing it to shrink when it is suppose to resize wider. I have a bunch of classwork to finish up for next week, but I will take a look at this over the weekend. Created attachment 270761 [details]
Patch
Comment on attachment 270761 [details] Patch Clearing flags on attachment: 270761 Committed r196187: <http://trac.webkit.org/changeset/196187> All reviewed patches have been landed. Closing bug. |
Created attachment 269708 [details] [Animated GIF] Bug See the attached GIF.