Summary: | WebKitTestRunner: Credential cache is not cleared between tests | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, ap, beidson, commit-queue, lforschler, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | 153451 | ||||||||||||
Bug Blocks: | 153250 | ||||||||||||
Attachments: |
|
Description
Daniel Bates
2016-01-24 10:59:41 PST
Created attachment 269756 [details]
Patch
Comment on attachment 269756 [details]
Patch
Mostly good, except it only sends the message to the NetworkProcess. I think we still need it sent to all WebProcesses, as well, since we still do some networking in the WebProcesses.
Created attachment 269757 [details]
Patch
Updated patch to send a message to all web processes to switch to a new testing network session in addition to sending a message to the network process.
Committed r195543: <http://trac.webkit.org/changeset/195543> This caused a pretty serious performance regression on tests, so creating a whole new session looks like too large of a hammer, unfortunately :( before: 13:18 13:31 13:42 13:34 13:39 after: 13:59 14:19 14:47 14:12 14:21 14:20 (In reply to comment #6) > This caused a pretty serious performance regression on tests, so creating a > whole new session looks like too large of a hammer, unfortunately :( > > before: > 13:18 > 13:31 > 13:42 > 13:34 > 13:39 > > after: > 13:59 > 14:19 > 14:47 > 14:12 > 14:21 > 14:20 Will rollout <http://trac.webkit.org/changeset/195543>. It should be sufficient to clear the credential cache directly. Re-opened since this is blocked by bug 153451 Created attachment 269825 [details]
Patch
Committed r195589: <http://trac.webkit.org/changeset/195589> |