Summary: | Reduce number of Structures created at startup | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||
Component: | JavaScriptCore | Assignee: | Andreas Kling <kling> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, keith_miller, mark.lam, msaboff, saam | ||||||||||
Priority: | P2 | Keywords: | Performance | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Andreas Kling
2016-01-23 05:18:35 PST
Created attachment 269669 [details]
Patch for EWS
Comment on attachment 269669 [details]
Patch for EWS
Nice.
Created attachment 269676 [details]
Patch
Cover a few more cases (non-index accessors and native getters.)
Comment on attachment 269676 [details] Patch Attachment 269676 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/730698 Number of test failures exceeded the failure limit. Created attachment 269677 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
I was thinking about doing this for a while. Glad it's getting done! Created attachment 269679 [details]
Patch
Back to the original patch + ChangeLog.
Can deal with the non-index accessors and stuff in a separate patch, and keep this one simple.
Comment on attachment 269679 [details]
Patch
Can you add some simple regression testing mechanism that will catch if someone get this wrong in the future? Maybe a count of structure transitions during the process of making the JSGlobalObject or something?
Comment on attachment 269679 [details] Patch Clearing flags on attachment: 269679 Committed r195528: <http://trac.webkit.org/changeset/195528> All reviewed patches have been landed. Closing bug. |