Bug 153399

Summary:

Reduce number of Structures created at startup

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

JavaScriptCore

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, msaboff, saam

Priority:

Keywords:

Performance

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for EWS	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews116 for mac-yosemite	none
Patch	none

Andreas Kling

Reported 2016-01-23 05:18:35 PST

For prototype and constructor objects, we should use JSObject::addPropertyWithoutTransition() as much as possible, to avoid creating tons of Structure transitions that won't get used for anything.

Attachments
Patch for EWS (50.55 KB, patch) 2016-01-23 05:19 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (62.98 KB, patch) 2016-01-23 14:34 PST, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-yosemite (348.76 KB, application/zip) 2016-01-23 15:21 PST, Build Bot	no flags	Details
Patch (53.59 KB, patch) 2016-01-23 16:11 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2016-01-23 05:19:11 PST

Created attachment 269669 [details] Patch for EWS

Mark Lam

Comment 2 2016-01-23 07:31:17 PST

Comment on attachment 269669 [details] Patch for EWS Nice.

Andreas Kling

Comment 3 2016-01-23 14:34:11 PST

Created attachment 269676 [details] Patch Cover a few more cases (non-index accessors and native getters.)

Build Bot

Comment 4 2016-01-23 15:21:40 PST

Comment on attachment 269676 [details] Patch Attachment 269676 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/730698 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2016-01-23 15:21:43 PST

Created attachment 269677 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5

Keith Miller

Comment 6 2016-01-23 15:32:05 PST

I was thinking about doing this for a while. Glad it's getting done!

Andreas Kling

Comment 7 2016-01-23 16:11:02 PST

Created attachment 269679 [details] Patch Back to the original patch + ChangeLog. Can deal with the non-index accessors and stuff in a separate patch, and keep this one simple.

Darin Adler

Comment 8 2016-01-24 12:14:14 PST

Comment on attachment 269679 [details] Patch Can you add some simple regression testing mechanism that will catch if someone get this wrong in the future? Maybe a count of structure transitions during the process of making the JSGlobalObject or something?

WebKit Commit Bot

Comment 9 2016-01-25 00:18:21 PST

Comment on attachment 269679 [details] Patch Clearing flags on attachment: 269679 Committed r195528: <http://trac.webkit.org/changeset/195528>

WebKit Commit Bot

Comment 10 2016-01-25 00:18:25 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.