Summary: | mandreel should run just as fast in FTL B3 as FTL LLVM | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, keith_miller, mark.lam, mhahnenb, msaboff, oliver, saam, sam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 150279 | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2016-01-22 21:46:42 PST
Created attachment 269648 [details]
work so far
Contains two optimizations:
- Branch on something that was already Checked should be turned into a Jump to the notTaken path.
- Gotta do more store-math-load fusion.
Created attachment 269658 [details]
the patch
Attachment 269658 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/b3/B3ReduceStrength.cpp:45: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:233: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:234: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:235: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:236: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:243: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 8 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 269659 [details]
current standings
Comment on attachment 269658 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=269658&action=review > Source/JavaScriptCore/assembler/X86Assembler.h:455 > + m_formatter.oneByteOp8(OP_ADD_EvGv, src, base, offset); Per conversation probably doesn't need to be oneByteOp8, in a future patch. > Source/JavaScriptCore/b3/B3PureCSE.cpp:54 > + Matches& matches = m_map.add(key, Matches()).iterator->value; add –> find > Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:243 > + mkasm(u, "l"); indentation! Landed in http://trac.webkit.org/changeset/195549 |